Stop @newtype to warn for implicit conversions #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcesquerra
force-pushed
the
ImplicitConversions
branch
3 times, most recently
from
d5d5b6e
to
c3057c8
Compare
marcesquerra
force-pushed
the
ImplicitConversions
branch
from
c3057c8
to
684655a
Compare
|
For some reason, travis-ci seems to be using a broken cache for the scala 2.13 build. I'm going to close this PR and open a new one to see if this gets fixed |
|
I've reopened this PR in here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you neither set the '-language:implicitConversions' flag, nor the 'import scala.language.implicitConversions', the '@newtype' construct warns for implicit conversions.
I've tried, and this PR prevents it.