Merge pull request #3677 from thyttan/messagegui

messagegui: fix assign entry to menu, not msg obj
espruino · Nov 29, 2024 · 1bd657a · 1bd657a
2 parents 73c3273 + 236a4c8
commit 1bd657a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/apps/messagegui/ChangeLog b/apps/messagegui/ChangeLog
@@ -112,3 +112,4 @@
       Add top-right menu to music playback to allow message to be deleted
 0.82: Stop buzzing when a message is removed (e.g. call answered)
 0.83: Add option to not open the first unread message
+0.84: Fix: Assign show message entry to the settings menu and not the message itself.
diff --git a/apps/messagegui/app.js b/apps/messagegui/app.js
@@ -283,7 +283,7 @@ function showMessageSettings(msg) {
   };
 
   if (msg.id!="music")
-    msg[/*LANG*/"View Message"] = () => showMessageScroller(msg);
+    menu[/*LANG*/"View Message"] = () => showMessageScroller(msg);
 
   if (msg.reply && reply) {
     menu[/*LANG*/"Reply"] = () => {

diff --git a/apps/messagegui/metadata.json b/apps/messagegui/metadata.json
@@ -2,7 +2,7 @@
   "id": "messagegui",
   "name": "Message UI",
   "shortName": "Messages",
-  "version": "0.83",
+  "version": "0.84",
   "description": "Default app to display notifications from iOS and Gadgetbridge/Android",
   "icon": "app.png",
   "type": "app",