-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IEP-1254: Fixing message to reflect ESP-IDF: Project Full Clean not just Project Clean for switched ESP-IDF Version #983
Conversation
…ust Project Clean for switched ESP-IDF Version
WalkthroughThe recent update modifies the ESP-IDF path configuration message in the IDE. Instead of instructing users to perform a "Project Clean," it now directs them to execute a "Project Full Clean" to ensure the active ESP-IDF configuration is used. This change aims to enhance clarity and ensure the correct configuration is applied. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change in messages.properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/messages.properties (1 hunks)
Additional comments not posted (1)
bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/messages.properties (1)
26-26
: The updated message is clear and aligns with the PR objectives.Verification successful
The search for the old message "ESP-IDF:Project Clean" did not produce any results, indicating that the message has likely been updated consistently across the project.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the updated message is consistently used across the project. # Test: Search for the old message. Expect: No occurrences of the old message. rg --type properties $'ESP-IDF:Project Clean'Length of output: 81
Script:
#!/bin/bash # Description: Verify that the updated message is consistently used across the project. # Test: Search for the old message. Expect: No occurrences of the old message. rg 'ESP-IDF:Project Clean'Length of output: 28
Description
Fixing message to reflect ESP-IDF: Project Full Clean not just Project Clean for switched ESP-IDF Version
Fixes # (IEP-1254)
Type of change
Please delete options that are not relevant.
How has this been tested?
Install two versions for esp-idf and build the project and then try to switch the esp-idf to another version and build project the updated message should reflect the user about using ESP-IDF:Project Full Clean command not Project Clean
Checklist
Summary by CodeRabbit