-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove slf4j plugin dependency #822
Conversation
Helps to fix Eclipse 2023-09 update error
WalkthroughThis pull request introduces a shift in the project dependencies and updates the repository location for a feature group. The changes primarily affect the terminal connector serial bundle and the target definition file. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Files selected for processing (1)
- bundles/com.espressif.idf.terminal.connector.serial/META-INF/MANIFEST.MF (1 hunks)
Additional comments (Suppressed): 1
bundles/com.espressif.idf.terminal.connector.serial/META-INF/MANIFEST.MF (1)
- 18-21: The
org.slf4j.api
bundle has been removed from theRequire-Bundle
section, which indicates that the dependency on the SLF4J plugin has been eliminated. This change is in line with the PR summary. However, ensure that all logging calls previously using SLF4J have been updated to use the new logging system (presumablyorg.eclipse.ui.console
). Also, verify that there are no remaining imports or references toorg.slf4j
in the codebase.
com.espressif.idf.ui, | ||
com.espressif.idf.serial.monitor, | ||
org.eclipse.cdt.core.native, | ||
org.eclipse.ui.console, | ||
org.slf4j.api | ||
org.eclipse.ui.console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding org.eclipse.ui.console
as a required bundle suggests a shift from SLF4J to Eclipse's console for logging or output purposes. Ensure that this bundle provides all the necessary functionalities and meets the performance requirements for your logging needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (1)
- releng/com.espressif.idf.target/com.espressif.idf.target.target (1 hunks)
Files skipped from review due to trivial changes (1)
- releng/com.espressif.idf.target/com.espressif.idf.target.target
Hi @AndriiFilippov Would you mind accepting this fix for v2.11.0 release, this would unblock update site issue which we are having with Eclipse 2023-09? Tests Required: |
Helps to fix Eclipse 2023-09 update error
Description
Remove slf4j plugin dependency
Fixes # (IEP-1025)
Type of change
How has this been tested?
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit
com.espressif.idf.terminal.connector.serial
project. Removed dependency onorg.slf4j.api
and added a new dependency onorg.eclipse.ui.console
for enhanced console functionality.org.eclipse.cdt.lsp.feature.feature.group
incom.espressif.idf.target
project. The new location points to the stable release of CDT Language Server Protocol (LSP) instead of the master build, improving reliability.