IEP-1022: Improve sdkconfig search functionality

[sigmaaa]

Description

Improved sdkconfig filter functionality. Now filtering allows compare not only the Kconfig elements' title but their names (UI labels) as well.

Fixes # (IEP-1022)

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

How has this been tested?

open sdkconfig editor. Try to search different components by label's name. For example "After flashing" gives

Test Configuration:

• ESP-IDF Version:
• OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

• sdkconfig

Checklist

• PR Self Reviewed
• Applied Code formatting
• Added Documentation
• Added Unit Test
• Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

• New Feature: Enhanced the search functionality in the SDK Configuration UI. Users can now search for KConfigMenuItem objects not only by their title property but also by their name property, providing a more comprehensive and flexible search experience.

[coderabbitai]

Walkthrough

The changes primarily focus on enhancing the search functionality in the SDKConfigurationFilter class. The isLeafMatch and recursiveMatch methods now consider both name and title properties of KConfigMenuItem for a match, improving the overall search accuracy.

Changes

File	Summary
.../sdk/config/ui/SDKConfigurationFilter.java	Enhanced search functionality by considering both name and title properties of KConfigMenuItem in isLeafMatch and recursiveMatch methods. Removed an unnecessary empty line.

🐇💻

In the land of code, where logic intertwines,
A rabbit hops, leaving traces of lines.
With each hop, a bug takes flight,
Making the codebase shine bright.
Now the search is smarter, it's no longer blind,
It seeks and finds, leaving no keyword behind. 🎉

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• Mention @coderabbitai in any review comment for bot assistance.
• Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

• Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
• Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
  resume reviews, enter @coderabbitai resume as any issue or review comment.

[sigmaaa]

self reviewed

[coderabbitai]

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between 31b7055 and 80a094c commits.

Files selected for processing (1)

• bundles/com.espressif.idf.sdk.config.ui/src/com/espressif/idf/sdk/config/ui/SDKConfigurationFilter.java (2 hunks)

Additional comments (Suppressed): 2

bundles/com.espressif.idf.sdk.config.ui/src/com/espressif/idf/sdk/config/ui/SDKConfigurationFilter.java (2)

• 10-21: The changes in this hunk look good. The function isLeafMatch now checks both the title and name of the KConfigMenuItem which should improve the search functionality as described in the PR summary.

• 25-36: This hunk also looks good. The function recursiveMatch now checks both the title and name of the KConfigMenuItem and its children, which should further enhance the search functionality.

[kolipakakondal]

This is really helpful. LGTM

[kolipakakondal]

Hi @AndriiFilippov Please verify this

[coderabbitai]

Review Status

Actionable comments generated: 0

Commits

Files that changed from the base of the PR and between 05177fd and 1e03b89.

Files selected for processing (1)

• bundles/com.espressif.idf.sdk.config.ui/src/com/espressif/idf/sdk/config/ui/SDKConfigurationFilter.java (2 hunks)

Additional comments (Suppressed): 2

bundles/com.espressif.idf.sdk.config.ui/src/com/espressif/idf/sdk/config/ui/SDKConfigurationFilter.java (2)

• 10-21: The changes in this hunk are enhancing the search functionality by allowing users to search for Kconfig elements not only by their titles but also by their names. This is a good improvement for usability.

• 25-36: Similar to the previous hunk, this change enhances the recursive search functionality by checking both the name and title of each KconfigMenuItem. This should improve the depth and accuracy of the search results.

[AndriiFilippov]

@sigmaaa hi!

Tested:
OS - Windows 10 / MacOS
ESP-IDF: v5.1.1

Able to find under name / update / save / build.
LGTM 👍