Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IEP-374: GCOV Reports view and creation #817
base: master
Are you sure you want to change the base?
IEP-374: GCOV Reports view and creation #817
Changes from 23 commits
b60cbf3
228164f
b46d51d
66772dc
a65fa9f
26da993
4fafdd1
506305f
81c1472
6b290bf
aed14f2
5c286e8
05ea147
7ed186c
0ab584f
b5c2381
cdc120a
83b4581
c3a6e21
5af363b
a5b71a6
e9289a8
1076037
4bac3ff
0f1d826
2519d20
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 30 in bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/GcovUtility.java
GitHub Actions / spotbugs
EI_EXPOSE_STATIC_REP2
Raw output
Check warning on line 35 in bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/GcovUtility.java
GitHub Actions / spotbugs
MS_EXPOSE_REP
Raw output
Check warning on line 55 in bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/GcovUtility.java
GitHub Actions / spotbugs
DLS_DEAD_LOCAL_STORE
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we follow same convention as esp-idf
Gcov Instant
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/app_trace.html#gcov-source-code-coverageThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/app_trace.html#gcov-source-code-coverage
same here
Check warning on line 1 in bundles/com.espressif.idf.debug.gdbjtag.openocd/src/com/espressif/idf/debug/gdbjtag/openocd/dsf/Launch.java
GitHub Actions / spotbugs
THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION
Raw output
Check warning on line 73 in bundles/com.espressif.idf.debug.gdbjtag.openocd/src/com/espressif/idf/debug/gdbjtag/openocd/dsf/Launch.java
GitHub Actions / spotbugs
EI_EXPOSE_REP2
Raw output
Check warning on line 74 in bundles/com.espressif.idf.debug.gdbjtag.openocd/src/com/espressif/idf/debug/gdbjtag/openocd/gcov/GcovDumpHandler.java
GitHub Actions / spotbugs
NP_NULL_ON_SOME_PATH
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can get the project directly from the launch configuration's mapped resources. Something like this:
configuration.getMappedResources()[0].getProject();
or something like this if you want to avoid null checks:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not clear on this we can use that approach but this should be fine too I think since the attribute ID comes from internal static constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if that's okay to use the class from the UI package here, since it can cause cyclic dependency later. Isn't it better to move this handler to the com.espressif.idf.ui.handlers package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some launch class dependencies there that are required and I am not sure if that can be good to add this package as a dependency to ui project
Check warning on line 46 in bundles/com.espressif.idf.serial.monitor/src/com/espressif/idf/serial/monitor/core/IDFMonitor.java
GitHub Actions / spotbugs
EI_EXPOSE_REP2
Raw output
Check warning on line 187 in bundles/com.espressif.idf.serial.monitor/src/com/espressif/idf/serial/monitor/core/IDFMonitor.java
GitHub Actions / spotbugs
THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION
Raw output