-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IEP-1279 Verify clangd editor features and find the gaps #1069
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe changes involve the addition of a new section titled "LSP Editor" in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
README.md (3)
311-321
: Maintain consistent list formattingFor better readability and consistency with the rest of the document, consider using asterisks (*) instead of dashes (-) for unordered lists. This applies to the steps for creating a virtual folder and searching ESP-IDF components.
🧰 Tools
🪛 Markdownlint
311-311: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
312-312: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
313-313: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
314-314: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
315-315: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
318-318: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
319-319: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
320-320: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
321-321: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
265-266
: Consider adding a brief explanation of LSPIt might be helpful to add a brief explanation of what LSP (Language Server Protocol) is and its benefits for users who may not be familiar with the term.
271-271
: Specify language for fenced code blocksTo improve syntax highlighting and adherence to Markdown best practices, specify the language for the fenced code blocks. For example, use
yaml for the .clang-format content and
shell for the command-line examples.Apply this change to the fenced code blocks:
-``` +```yaml BasedOnStyle: LLVM UseTab: Always ...-``` +``` project - managed_components ...-``` +```yaml CompileFlags: CompilationDatabase: build ...Also applies to: 282-282, 299-299
🧰 Tools
🪛 Markdownlint
271-271: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- README.md (2 hunks)
🧰 Additional context used
🪛 Markdownlint
README.md
40-40: null
Spaces inside link text(MD039, no-space-in-links)
311-311: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
312-312: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
313-313: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
314-314: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
315-315: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
318-318: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
319-319: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
320-320: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
321-321: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
271-271: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
282-282: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
299-299: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
🪛 LanguageTool
README.md
[style] ~289-~289: Consider using a different adverb to strengthen your wording.
Context: ... folder. This flag tells ClangFormat to completely ignore this specific.clang-format
fi...(COMPLETELY_ENTIRELY)
🔇 Additional comments (1)
README.md (1)
264-322
: New LSP Editor section looks good!The new section provides valuable information about the LSP Editor introduced in Espressif IDE 3.0.0. It covers important aspects such as formatting, search capabilities, inlay hints, and instructions for searching ESP-IDF components. The content is well-structured and informative.
🧰 Tools
🪛 LanguageTool
[style] ~289-~289: Consider using a different adverb to strengthen your wording.
Context: ... folder. This flag tells ClangFormat to completely ignore this specific.clang-format
fi...(COMPLETELY_ENTIRELY)
🪛 Markdownlint
311-311: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
312-312: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
313-313: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
314-314: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
315-315: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
318-318: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
319-319: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
320-320: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
321-321: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
271-271: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
282-282: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
299-299: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
- Click on **Advanced.** | ||
- Select **Link to alternate Location (Linked Folder)**. | ||
- Click **Browse** and select the `ESP-IDF components` folder. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the below recommendation as well -
It is recommended to always create a new project instead of modifying your current one to avoid unnecessary Git files and error markers created by the indexer for the components folder. As both the projects will be in the same workspace, you should be able to search anywhere within your workspace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Updating the README to clarify differences with the old editor
Fixes # (IEP-1279)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit