Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledc check (IDFGH-14066) #14881

Closed
wants to merge 873 commits into from
Closed

Conversation

IhorNehrutsa
Copy link
Contributor

Description

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

suda-morris and others added 30 commits July 25, 2024 16:41
Ci(spi_lcd): re-enable spi lcd test on p4 (v5.3)

See merge request espressif/esp-idf!32073
psram: bss in psram p4 (v5.3)

See merge request espressif/esp-idf!32124
…3' into 'release/v5.3'

dma: fix esp_dma_is_buffer_alignment_satisfied align issue when l2 cache line 128B (v5.3)

See merge request espressif/esp-idf!32205
…v5.3'

fix(psram): fixed p4 psram 20M wrong clk div (v5.3)

See merge request espressif/esp-idf!32255
camera: fixed csi and isp_dvp c2m cache ops (v5.3)

See merge request espressif/esp-idf!32293
…v5.3'

fix(usb_dwc_hal): Enabled precise detection of VBUS backport to v5.3

See merge request espressif/esp-idf!32059
…v5.3'

fix(usb/host): Decode error flags in ISOC transfers backport to v5.3

See merge request espressif/esp-idf!31884
feat(dvp): DVP cam supports more color format and don't initialize xclock pin (v5.3)

See merge request espressif/esp-idf!32023
…' into 'release/v5.3'

fix(hal): updated ecdsa reset api to execute correctly (v5.3)

See merge request espressif/esp-idf!32338
fix(hal): correct mpi/ecc peripheral power up sequence for ESP32-C5 (v5.3)

See merge request espressif/esp-idf!31728
…' into 'release/v5.3'

fix(tools/esp_prov): Fix incorrect input decoding when using console transport (v5.3)

See merge request espressif/esp-idf!31689
feat: add esp32p4 APM HAL/LL API (v5.3)

See merge request espressif/esp-idf!31417
fix(esp_http_client): Do not allocate client->if_name twice in esp_http_client_init. (GitHub PR) (v5.3)

See merge request espressif/esp-idf!31942
fix(rmt): power up memory block (v5.3)

See merge request espressif/esp-idf!32171
fix(i2c): Fix i2c not release semaphore in command send loop(backport v5.3)

See merge request espressif/esp-idf!31958
Feat/optimize bt porting hci 0628 5.3

See merge request espressif/esp-idf!32135
Icarus113 and others added 24 commits August 14, 2024 14:57
…lease/v5.3'

Bugfix/fixed ble issues on c6 h2 c2 0731 (v5.3)

See merge request espressif/esp-idf!32460
…release/v5.3'

doc(psram): move xip psram doc out from non updated list (v5.3)

See merge request espressif/esp-idf!32841
…o 'release/v5.3'

fix(openthread): make ot task queue sending non-permanent blocking(backport5.3)

See merge request espressif/esp-idf!32630
…release/v5.3'

rtc: fixed non-iram rtc code in early stage on p4 leading xip_psram stuck (v5.3)

See merge request espressif/esp-idf!32679
…ease/v5.3'

fix(mbedtls/aes): Avoid extra C2M sync of memory (v5.3)

See merge request espressif/esp-idf!32699
- Fixed the issue of disconnection caused by updating the channel map in sniff mode
Fix encrypt image instead of the partition optimisation not being enabled (v5.3)

See merge request espressif/esp-idf!32639
change: exclude CVEs that do not impact ESP-IDF components (v5.3)

See merge request espressif/esp-idf!32659
fix(bootloader): update random disable api for ESP32-C5/C6 (v5.3)

See merge request espressif/esp-idf!32761
… into 'release/v5.3'

fix(ble): fixed blufi issue on ESP32-C2 (v5.3)

See merge request espressif/esp-idf!32942
fix(bt/bluedroid): Add PCM configuration about pcm frame sync signal shape (backport v5.3)

See merge request espressif/esp-idf!32483
- Fixed BLE vendor HCI get controller status command
…ase/v5.3'

fix(bt/controller): Fixed bluetooth disconnect issue after modem sleep on ESP32 (Backport v5.3)

See merge request espressif/esp-idf!32963
fix(psram): fixed ap3204 id check (v5.3)

See merge request espressif/esp-idf!33109
    The flash encryption on esp32p4 was broken due to code related
    to key manager not being executed when key manager support was
    disabled on esp32p4 target.
    This commit fixes that behaviour
    Additionally, the atomic env enablement for
    key_mgr_ll_enable_peripheral_clock was fixed.
fix(security): Fixed flash encryption for esp32p4 (v5.3)

See merge request espressif/esp-idf!33140
@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 21 committers have signed the CLA.

✅ IhorNehrutsa
❌ igrr
❌ dobairoland
❌ mahavirj
❌ Isl2017
❌ suda-morris
❌ mythbuster5
❌ rahult-github
❌ jack0c
❌ ginkgm
❌ fhrbata
❌ zwx1995esp
❌ Harshal5
❌ ESP-Marius
❌ AdityaHPatwardhan
❌ esp-qing
❌ xiongweichao
❌ zhaoweiliang2021
❌ Icarus113
❌ esp-lrh
❌ esp-cjh
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message " fix(bt): Update bt lib for ESP32-C3 and ESP32-S3(abd7733)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Apply 1 suggestion(s) to 1 file(s)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Apply 35 suggestion(s) to 1 file(s)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Merge branch 'fix/ble_mesh_24_76_v5.3' into 'release/v5.3'":
    • probably contains Jira ticket reference (BLEMESH24-76). Please remove Jira tickets from commit messages.
  • the commit message "change: exclude CVEs that do not impact ESP-IDF components":
    • probably contains Jira ticket reference (CVE-2024, CVE-2024). Please remove Jira tickets from commit messages.
  • the commit message "docs(ble): Revised the explanation for esp_bt_mem_release and esp_bt_controller_mem_release":
    • summary appears to be too long
  • the commit message "docs(ble):Added the parameter name data in esp_vhci_host_send_packet":
    • summary looks empty
    • type/action looks empty
  • the commit message "examples/ledc_check.c: Check freq and duty.":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty
  • the commit message "feat(eth) configure eth mac using esp_read_mac":
    • summary looks empty
    • type/action looks empty
  • the commit message "feat(psram): support APS3204L":
    • summary looks too short
  • the commit message "fix(wpa_supplicant):Deinit old dpp authentication data after receiving config.":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 250 commits (simplifying branch history).
Messages
📖 This PR seems to be quite large (total lines of code: 89388), you might consider splitting it into smaller PRs

👋 Hello IhorNehrutsa, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 52031f2

@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 13, 2024
@github-actions github-actions bot changed the title Ledc check Ledc check (IDFGH-14066) Nov 13, 2024
@IhorNehrutsa IhorNehrutsa deleted the ledc_check branch November 13, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.