Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nan_console): Error when NAN Discovery is started more than once (IDFGH-13923) #14762

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

entrop1a
Copy link

@entrop1a entrop1a commented Oct 22, 2024

Description

  • Development board: ESP32-WROOM-32
  • ESP-IDF version: 5.4.0

In nan_console example, when NAN is started more than once, triggers this netif error: esp_netif_lwip: esp_netif_new_api: Failed to configure netif with config=0x3ffc85e0 (config or if_key is NULL or duplicate key). This means that the existence of a created network interface was not checked.

To resolve this problem, three actions were taken:

  1. Declaration of variable as null g_nan_netif;
  2. Before creating the network interface, g_nan_netif is checked;
  3. When NAN is stopped, g_nan_netif gets NULL.

Testing

Error log:
Screenshot from 2024-10-21 23-30-57

Fixed log:
Screenshot from 2024-10-21 23-34-33

Copy link

github-actions bot commented Oct 22, 2024

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello entrop1a, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 71d2e16

@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 22, 2024
@github-actions github-actions bot changed the title fix(nan_console): Error when NAN Discovery is started more than once fix(nan_console): Error when NAN Discovery is started more than once (IDFGH-13923) Oct 22, 2024
@entrop1a entrop1a force-pushed the fix-nan_console-start branch from 08dad37 to 83ec999 Compare October 22, 2024 15:41
@entrop1a entrop1a force-pushed the fix-nan_console-start branch from d8787d6 to 4301645 Compare October 23, 2024 00:35
@nachiketkukade
Copy link
Collaborator

@entrop1a , thanks for your contribution, with the minor modification mentioned above, will take the PR for internal review

@entrop1a
Copy link
Author

entrop1a commented Nov 1, 2024

@nachiketkukade, thanks for your review! Modifications have been made.

@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Work is in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants