-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #12779 (IDFGH-11667) #12780
Conversation
👋 Hello dyarkovoy, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
The linked issue is a valid requirement to be able to use the same project in Vscode and terminal as well but I don't think that we should sacrifice case-sensitive comparison on the ESP-IDF side in order to achieve that. Note that this fix is not limited to just the drive letter on Windows and case-insensitive filesystems. Case sensitive Windows, Linux and macOS case difference in all part of the path would be ignored as well. |
You're right, @dobairoland, we should not sacrifice case-sensitive comparison on case-sensitive filesystems. But the fix I suggest will only affect case-insensitive filesystem on Windows. If you look at the proposed commit, I use the
|
Thanks @dyarkovoy. My mistake. You are right. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested that the effect of this change is only on Windows platform and solves the issue #12779. Thanks @dyarkovoy.
sha=392fc6c740a2065bb6155a859a7c167e2c46331e |
fix(esp32): This should fix python path issue on Windows
This fixes idf.py error
c:\work\esp32.espressif\python_env\idf5.3_py3.11_env\Scripts\python.exe' is currently active in the environment while the project was configured with 'C:\work\esp32.espressif\python_env\idf5.3_py3.11_env\Scripts\python.exe'. Run 'idf.py fullclean' to start again
on Windows