Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #12779 (IDFGH-11667) #12780

Closed
wants to merge 1 commit into from

Conversation

dyarkovoy
Copy link
Contributor

@dyarkovoy dyarkovoy commented Dec 12, 2023

fix(esp32): This should fix python path issue on Windows
This fixes idf.py error

c:\work\esp32.espressif\python_env\idf5.3_py3.11_env\Scripts\python.exe' is currently active in the environment while the project was configured with 'C:\work\esp32.espressif\python_env\idf5.3_py3.11_env\Scripts\python.exe'. Run 'idf.py fullclean' to start again

on Windows

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Dec 12, 2023

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Fix for issue #12779":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello dyarkovoy, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 392fc6c

@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 12, 2023
@github-actions github-actions bot changed the title Fix for issue #12779 Fix for issue #12779 (IDFGH-11667) Dec 12, 2023
@dobairoland
Copy link
Collaborator

The linked issue is a valid requirement to be able to use the same project in Vscode and terminal as well but I don't think that we should sacrifice case-sensitive comparison on the ESP-IDF side in order to achieve that. Note that this fix is not limited to just the drive letter on Windows and case-insensitive filesystems. Case sensitive Windows, Linux and macOS case difference in all part of the path would be ignored as well.

@dyarkovoy
Copy link
Contributor Author

You're right, @dobairoland, we should not sacrifice case-sensitive comparison on case-sensitive filesystems. But the fix I suggest will only affect case-insensitive filesystem on Windows. If you look at the proposed commit, I use the os.path.normcase() Python function. Looking at Python docs :

os.path.normcase(path)
Normalize the case of a pathname. On Windows, convert all characters in the pathname 
to lowercase, and also convert forward slashes to backward slashes. 
On other operating systems, return the path unchanged.

@dobairoland
Copy link
Collaborator

Thanks @dyarkovoy. My mistake. You are right. Thanks!

Copy link
Collaborator

@jakub-kocka jakub-kocka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that the effect of this change is only on Windows platform and solves the issue #12779. Thanks @dyarkovoy.

@dobairoland
Copy link
Collaborator

sha=392fc6c740a2065bb6155a859a7c167e2c46331e

@dobairoland dobairoland added the PR-Sync-Merge Pull request sync as merge commit label Dec 13, 2023
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new labels Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python path case sensitivity issue on Windows (IDFGH-11666)
5 participants