Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assert failed in example uart_async_rxtxtasks (IDFGH-11380) #12523

Merged

Conversation

DYFeng
Copy link
Contributor

@DYFeng DYFeng commented Nov 4, 2023

In esp-idf/components/freertos/FreeRTOS-Kernel/tasks.c:1127, verify uxPriority must be less than configMAX_PRIORITIES.

    /* This is used as an array index so must ensure it's not too large. */
    configASSERT( uxPriority < configMAX_PRIORITIES );

In the example, uxPriority equals configMAX_PRIORITIES, resulting in a failed assert.

xTaskCreate(rx_task, "uart_rx_task", 1024 * 2, NULL, configMAX_PRIORITIES, NULL);

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Nov 4, 2023

Messages
📖 Good Job! All checks are passing!

👋 Welcome DYFeng, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

Generated by 🚫 dangerJS against b8a3141

@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 4, 2023
@github-actions github-actions bot changed the title fix: assert failed in example uart_async_rxtxtasks fix: assert failed in example uart_async_rxtxtasks (IDFGH-11380) Nov 4, 2023
@espressif-bot espressif-bot assigned Dazza0 and songruo and unassigned Dazza0 Nov 6, 2023
@Dazza0
Copy link
Contributor

Dazza0 commented Nov 6, 2023

@DYFeng Thanks for the fix. Changes LGTM.

@Dazza0
Copy link
Contributor

Dazza0 commented Nov 6, 2023

sha=b8a3141ef96d655271f9b4634c559b61a2bef2be

@Dazza0 Dazza0 added the PR-Sync-Merge Pull request sync as merge commit label Nov 6, 2023
@Dazza0 Dazza0 self-assigned this Nov 6, 2023
@Dazza0 Dazza0 self-requested a review November 6, 2023 03:36
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new labels Nov 6, 2023
@espressif-bot espressif-bot merged commit 455cc34 into espressif:master Nov 7, 2023
7 checks passed
@DYFeng DYFeng deleted the fix-example-uart_async_rxtxtasks branch November 18, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants