Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "error code" Typo (IDFGH-11162) #12330

Closed
wants to merge 1 commit into from

Conversation

nkaaf
Copy link
Contributor

@nkaaf nkaaf commented Sep 29, 2023

Fixed miss spelled words in WiFi files: "erro code" -> "error code"

Update Copyright year

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Warnings
⚠️ The PR description looks very brief, please check if more details can be added.

👋 Welcome nkaaf, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

🔁 You can re-run automatic PR checks by retrying the DangerJS action

Generated by 🚫 dangerJS against 51e6d22

@espressif-bot espressif-bot added the Status: Opened Issue is new label Sep 29, 2023
@github-actions github-actions bot changed the title Fix "error code" Typo Fix "error code" Typo (IDFGH-11162) Sep 29, 2023
@mahavirj
Copy link
Member

mahavirj commented Oct 3, 2023

sha=51e6d228b446a083d35b5b8e6ece1b9b7c127b10

@mahavirj mahavirj added the PR-Sync-Merge Pull request sync as merge commit label Oct 3, 2023
@jack0c jack0c closed this Oct 16, 2023
@jack0c jack0c reopened this Oct 16, 2023
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new labels Oct 16, 2023
@nkaaf
Copy link
Contributor Author

nkaaf commented Oct 25, 2023

Is there anything I can improve/fix, or why is the PR closed? :)

@igrr
Copy link
Member

igrr commented Oct 25, 2023

Thanks for your PR @nkaaf, your commit was merged in 2d6dcee (the link to the commit is right above). We sometimes have to rebase Github PRs before merging them into the master branch, and in this case Github doesn't associate the commit with the PR and doesn't mark the PR is "merged", even though effectively it is. The rebased commit still has you as the author, your contribution is very much appreciated!

@nkaaf
Copy link
Contributor Author

nkaaf commented Oct 25, 2023

I understand, perfect. :)

1 similar comment
@nkaaf
Copy link
Contributor Author

nkaaf commented Oct 25, 2023

I understand, perfect. :)

movsb pushed a commit to movsb/esp-idf that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants