Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update host-based-security-workflows.rst (IDFGH-11090) #12262

Closed
wants to merge 2 commits into from

Conversation

walerii
Copy link
Contributor

@walerii walerii commented Sep 18, 2023

Fixed typos in the code examples which caused troubles when trying to follow the secure boot workflow and improved the grammar.

Fixed typos in the code examples which caused troubles when trying to follow the secure boot workflow and improved the grammar.
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2023

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Sep 18, 2023
@github-actions github-actions bot changed the title Update host-based-security-workflows.rst Update host-based-security-workflows.rst (IDFGH-11090) Sep 18, 2023
@AdityaHPatwardhan
Copy link
Collaborator

AdityaHPatwardhan commented Sep 27, 2023

@walerii Thanks for the PR, I will take it up internally.

Copy link
Collaborator

@Harshal5 Harshal5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Warnings
⚠️

Some issues found for the commit messages in this MR:

  • the commit message Update host-based-security-workflows.rst appears to be a temporary or automatically generated message
  • the commit message Update host-based-security-workflows.rst appears to be a temporary or automatically generated message

Please consider updating these commit messages.


👋 Welcome walerii, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

🔁 You can re-run automatic PR checks by retrying the DangerJS action

Generated by 🚫 dangerJS against b5589db

@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Oct 3, 2023
@AdityaHPatwardhan AdityaHPatwardhan added the PR-Sync-Merge Pull request sync as merge commit label Oct 3, 2023
@AdityaHPatwardhan
Copy link
Collaborator

AdityaHPatwardhan commented Oct 3, 2023

@walerii Thanks for adding suggested changes, Can you please just merge both commits into one.

@mahavirj
Copy link
Member

@walerii Can you please squash the commits?

@walerii
Copy link
Contributor Author

walerii commented Oct 12, 2023

@mahavirj unfortunately I am not sure how to do this.
Additional guidance is highly appreciated.

@AdityaHPatwardhan
Copy link
Collaborator

@walerii Can you please mention that software interface you have used to raise the PR?
Are you using Git CLI or some software like Git Desktop?
Based on that we can give you some guidelines.

@AdityaHPatwardhan
Copy link
Collaborator

@walerii Can you please find time to merge the commits.
I can surely do that on my end, but that would put it something like
you authored the commit
But someone else committed the changes.
If it comes from you it is cleaner and most recommended.
Thanks,
Aditya

@AdityaHPatwardhan
Copy link
Collaborator

sha=b47536e955906a7c1f60dd725ae86c4b9c14e089

@AdityaHPatwardhan
Copy link
Collaborator

@walerii Thanks again for you contribution.
I am going ahead with the internal merge for this MR.

@AdityaHPatwardhan
Copy link
Collaborator

sha=b5589db377ebb2b0489593b82477bca6a53fa384

@AdityaHPatwardhan AdityaHPatwardhan added PR-Sync-Merge Pull request sync as merge commit and removed PR-Sync-Merge Pull request sync as merge commit labels Oct 17, 2023
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: In Progress Work is in progress labels Oct 18, 2023
movsb pushed a commit to movsb/esp-idf that referenced this pull request Dec 1, 2023
Fixed typos in the code examples which caused troubles when trying to follow the secure boot workflow and improved the grammar.

Closes espressif#12262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants