-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update host-based-security-workflows.rst (IDFGH-11090) #12262
Conversation
Fixed typos in the code examples which caused troubles when trying to follow the secure boot workflow and improved the grammar.
@walerii Thanks for the PR, I will take it up internally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
👋 Welcome walerii, thank you for your first contribution to 📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project. Pull request review and merge process you can expectEspressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.
🔁 You can re-run automatic PR checks by retrying the DangerJS action |
@walerii Thanks for adding suggested changes, Can you please just merge both commits into one. |
@walerii Can you please squash the commits? |
@mahavirj unfortunately I am not sure how to do this. |
@walerii Can you please mention that software interface you have used to raise the PR? |
@walerii Can you please find time to merge the commits. |
sha=b47536e955906a7c1f60dd725ae86c4b9c14e089 |
@walerii Thanks again for you contribution. |
sha=b5589db377ebb2b0489593b82477bca6a53fa384 |
Fixed typos in the code examples which caused troubles when trying to follow the secure boot workflow and improved the grammar. Closes espressif#12262
Fixed typos in the code examples which caused troubles when trying to follow the secure boot workflow and improved the grammar.