Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug Helpers] add esp_backtrace_print_all_tasks function (IDFGH-10315) #11575

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions components/esp_system/include/esp_debug_helpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ extern "C" {

#ifndef __ASSEMBLER__

#if CONFIG_FREERTOS_ENABLE_TASK_SNAPSHOT
#include "freertos/FreeRTOS.h"
#include "freertos/task_snapshot.h"
#endif

#include <stdbool.h>
#include "esp_err.h"
#include "soc/soc.h" // [refactor-todo] IDF-2297
Expand Down Expand Up @@ -109,6 +114,28 @@ esp_err_t esp_backtrace_print_from_frame(int depth, const esp_backtrace_frame_t*
*/
esp_err_t esp_backtrace_print(int depth);

#if CONFIG_FREERTOS_ENABLE_TASK_SNAPSHOT
/**
* @brief Convert a FreeRTOS TaskSnapshot into a esp_backtrace_frame_t
*
* @param snapshot The task snapshot, from vTaskGetSnapshot or uxTaskGetSnapshotAll
*
* @return the backtrace frame
*/
esp_backtrace_frame_t esp_task_snapshot_to_backtrace_frame(TaskSnapshot_t snapshot);

/**
* @brief Print the backtrace of every task on the system
*
* @param depth The maximum number of stack frames to print (should be > 0)
*
* @return
* - ESP_OK All backtraces successfully printed to completion or to depth limit
* - ESP_FAIL One or more backtraces is corrupt
*/
esp_err_t esp_backtrace_print_all_tasks(int depth, bool panic);
#endif

/**
* @brief Set a watchpoint to break/panic when a certain memory range is accessed.
* Superseded by esp_cpu_set_watchpoint in esp_cpu.h.
Expand Down
65 changes: 65 additions & 0 deletions components/esp_system/port/arch/xtensa/debug_helpers.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@
#include <string.h>

#include "sdkconfig.h"

#if CONFIG_FREERTOS_ENABLE_TASK_SNAPSHOT
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#include "freertos/task_snapshot.h"
#endif

#include "esp_types.h"
#include "esp_attr.h"
#include "esp_err.h"
Expand Down Expand Up @@ -101,3 +108,61 @@ esp_err_t IRAM_ATTR esp_backtrace_print(int depth)
esp_backtrace_get_start(&(start.pc), &(start.sp), &(start.next_pc));
return esp_backtrace_print_from_frame(depth, &start, false);
}


#if CONFIG_FREERTOS_ENABLE_TASK_SNAPSHOT

esp_backtrace_frame_t esp_task_snapshot_to_backtrace_frame(TaskSnapshot_t snapshot)
{
XtExcFrame* xtf = (XtExcFrame*)snapshot.pxTopOfStack;

esp_backtrace_frame_t frame = {
.pc = xtf->pc,
.sp = xtf->a1,
.next_pc = xtf->a0,
.exc_frame = xtf,
};

return frame;
}

esp_err_t IRAM_ATTR esp_backtrace_print_all_tasks(int depth, bool panic)
{
// todo: should we disable context switching, and the other core?
// It works fine without that, but still seems like a good idea.

uint32_t task_count = uxTaskGetNumberOfTasks();

TaskSnapshot_t* snapshots = (TaskSnapshot_t*) calloc(task_count * sizeof(TaskSnapshot_t), 1);

// get snapshots
UBaseType_t tcb_size = 0;
uint32_t got = uxTaskGetSnapshotAll(snapshots, task_count, &tcb_size);

uint32_t len = got < task_count ? got : task_count;

print_str("printing all tasks:\n\n", panic);

esp_err_t err = ESP_OK;

for (uint32_t i = 0; i < len; i++) {

TaskHandle_t handle = (TaskHandle_t) snapshots[i].pxTCB;

char* name = pcTaskGetName(handle);

print_str(name ? name : "No Name" , panic);

esp_backtrace_frame_t frame = esp_task_snapshot_to_backtrace_frame(snapshots[i]);

esp_err_t nerr = esp_backtrace_print_from_frame(depth, &frame, panic);
if (nerr != ESP_OK) {
err = nerr;
}
}

free(snapshots);
return err;
}

#endif // CONFIG_FREERTOS_ENABLE_TASK_SNAPSHOT