Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp_codec_dev: Fix volume setting for ES8374 (AUD-5742) #1285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robert-alfaro
Copy link

@robert-alfaro robert-alfaro commented Sep 30, 2024

Description

Fixes output volume setting for ES8374 codec in the esp_codec_dev component. Bug was introduced when the component was created. The problem is the db_value, mapped from a volume integer, needs to be converted to a register value, however the incorrect method esp_codec_dev_vol_calc_db is used. It should be esp_codec_dev_vol_calc_reg.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title esp_codec_dev: Fix volume setting for ES8374 esp_codec_dev: Fix volume setting for ES8374 (AUD-5742) Sep 30, 2024
@robert-alfaro
Copy link
Author

@TempoTian

@TempoTian
Copy link
Contributor

I have prepared a commit for this change, it will merge soon. For we internally manage gitlab, to keep code consistent, we need commit from internal gitlab.
Thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants