Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(variant): Arduino Nano ESP32 variant fix for core 3 #9722

Merged
merged 1 commit into from
May 30, 2024

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented May 29, 2024

I don't know what hack that is including cpp files, but without this PR every build for this board fails with core 3. linker can't find bytes2hex from HEXBuilder.

I just unpacked my new Nano ESP32. I wonder why nobody cares about this board with core 3.

Copy link
Contributor

github-actions bot commented May 29, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello JAndrassy, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 97ce4a1

@me-no-dev
Copy link
Member

@pillo79 PTAL

Copy link
Contributor

github-actions bot commented May 29, 2024

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 97ce4a1.

♻️ This comment has been updated with latest results.

@pillo79
Copy link
Contributor

pillo79 commented May 30, 2024

Sorry, my bad for not checking it after the betas. I confirm this is the proper fix, thanks @JAndrassy! 🙇

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards labels May 30, 2024
@me-no-dev me-no-dev merged commit f1cb6b8 into espressif:master May 30, 2024
234 checks passed
@JAndrassy JAndrassy deleted the arduino_nano_fix branch May 30, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants