feat(platform)[2.x]: Use iwithprefixbefore to shorten the command lines #10622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command line for the ESP32 compilers is very long, and it is causing
problems with the Arduino IDE on Windows systems, which enforce a hard
32kB string limit.
This patch uses the iprefix/iwithprefixbefore options to shorten the
compiler command line by changing
"-I{compiler.sdk.path}/include/aaa"
"-I{compiler.sdk.path}/include/bbb"
"-I{compiler.sdk.path}/include/ccc"
...
to:
-iprefix "{compiler.sdk.path}/include/"
-iwithprefixbefore aaa
-iwithprefixbefore bbb
-iwithprefixbefore ccc
...
Some targets have up to 200 paths so this can save A LOT of text.
On a sample run this patch shortened a single compile command from
28777 bytes to 10728.
|
@pillo79 do you plan to move away from 2.x? |
|
@me-no-dev We definitely do, it's just that we need some careful pivot strategy instead of pushing a 3.x point blank to everyone. There's also a reported issue with the Nano and the recovery firmware we need to look into in more detail. We will have to allow using 2.x for a long time I guess, and this linked issue was reported several times in the past as well from users with long names, so I looked into a fix. I've pushed this in our branch as a blanket "sed", but I was about to ask if that was the proper fix for upstream (or if you still accept developments on the 2.x release at all 🙂). |
|
fix looks OK, we use the same trick for 3.x, though for different reasons. We no longer push anything to 2.x and IDF 4.4 is EOL, but we will accept fixes. I suggest you look into 3.1 as it comes with ZigBee, Thread and Matter (along with many fixes and refactoring of included classes and tools) |
|
I had initial reports that said it was working flawlessly, but one tester later reported issues such as the following: The weird thing is that this file is there, in the same directory that contains the including file - which was obviously found. This was reproduced in a different PC... on a different file that gcc still "refuses" to find. We are investigating. |
|
Issue there is the length of the path on Windows. In newer versions we have renamed the packages with the toolchains to a very short ones in order to help the situation when users have longer usernames |
|
Wow, I did not notice at first there were two different limits at play! 🤦♂️ Since there's already a proper fix for this in 3.x and this repo is EOL'd, we'll keep this in our downstream for the time being. Again thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The command line for the ESP32 compilers is very long, and it is causing problems with the Arduino IDE on Windows systems which enforce a hard 32kB string limit.
This PR uses the
-iprefix/-iwithprefixbeforeoptions to shorten the compiler command line by changingto:
Some targets have up to 200 paths so this can save A LOT of text. On a sample run this patch shortened a single compile command from 28777 bytes to 10728.
Tests scenarios
Tested on Arduino IDE 2.3.3 on Windows 10 for the Arduino Nano ESP32 target (S3 based), with a username containing spaces and non-ASCII UTF-8 chars.
Related links
Related issue on the arduino-cli repo: arduino/arduino-cli#2716