-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(uart): only enable on_receive task if necessary #10423
Conversation
The onReceive Task was created by default when Serial.begin() is executed. This creates a additonal Task that degrades the performance of the whole arduino sketch. This will be done now only if onReceive() is called.
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 56 files - 96 56 suites - 96 4m 12s ⏱️ - 34m 32s Results for commit 5e472cb. ± Comparison against base commit 8ce5f77. This pull request removes 15 tests.
|
After testing it .... everything point to the UART Driver itself! |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Description of Change
The onReceive Task was created by default when Serial.begin() is executed. This creates a additonal Task that degrades the performance of the whole arduino sketch.
This will be done now only if onReceive() is called.
Tests scenarios
Related links
closes #10397
closes #10420