-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes exceptions resulting from using SPI0Command #9140
Conversation
…perations such as: Write Status Register-1, Sector Eraser, etc. Moved PRECACHE_END to ensure `Wait_SPI_Idlep` and `xt_wsr_ps` are included in the iCache. Added SPIUCSSETUP to give more settling time for #CS.
and the "target opcode". They are now tightly coupled. Update flash quirks.
Let's put this on hold. I need to look closer at the sequence of calls used when doing write enabled by other examples. Some examples poll the status register until bit WEL is set before continuing. |
SPI_write_enable for the special handling of the WEL bit. Corrected zero mask for fractional byte returns where the partial byte bits are positioned at the most significant bit position in the byte.
Still on hold? Is this related to a specific flash chip? Or does this happen at random (or not so forced random) on any hardware? |
It looks ready. I haven't found any more issues.
This may be me overanalyzing and being over-cautious. The BootROM's |
* Resolves exceptions occuring when using SPI0Command for flash write operations such as: Write Status Register-1, Sector Eraser, etc. Moved PRECACHE_END to ensure `Wait_SPI_Idlep` and `xt_wsr_ps` are included in the iCache. Added SPIUCSSETUP to give more settling time for #CS. * There was a risk of flash reads inserted between an "enable opcode" and the "target opcode". They are now tightly coupled. Update flash quirks. * When sending instruction Write Enable 0x06, use BootROM API SPI_write_enable for the special handling of the WEL bit. Corrected zero mask for fractional byte returns where the partial byte bits are positioned at the most significant bit position in the byte.
Resolves exceptions occurring when using
experimental::SPI0Command
for flash write operations such as: Write Status Register-1, Sector Eraser, etc.Moved PRECACHE_END to ensure
Wait_SPI_Idlep
andxt_wsr_ps
are included in the iCache.Added SPIUCSSETUP to give more settling time for #CS.