New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiFi wl_enc_type enum update #9116

Open

JAndrassy wants to merge 2 commits into esp8266:master from JAndrassy:wifi_enc_type_enum_update

Contributor

JAndrassy commented Mar 31, 2024

the wl_enc_type enum is from the first Arduino WiFi library and is part of the Arduino WiFi API.
It is updated in newer WiFi libraries by Arduino.

JAndrassy and others added 2 commits

March 31, 2024 14:06


          WiFi wl_enc_type enum update

df3a499


          Merge branch 'master' into wifi_enc_type_enum_update

62b162b

Collaborator

mcspr commented Mar 31, 2024

Not upstream everywhere, yet
https://github.com/arduino/ArduinoCore-renesas/blob/3dd08de860915a3577c232d3c0c2a66d33e04df7/libraries/WiFiS3/src/WiFiTypes.h#L20-L32 UNO R4 deployed these

Still pending for older cores
arduino-libraries/WiFi101#350
arduino-libraries/WiFiNINA#259

I would guess this should be ok here, actively saving from undefined enum errors and architecture ifdefs

Contributor Author

JAndrassy commented Mar 31, 2024 •

edited

Loading

the other WiFi library in the Renesas Core has the enum here https://github.com/arduino/ArduinoCore-renesas/blob/3dd08de860915a3577c232d3c0c2a66d33e04df7/libraries/lwIpWrapper/src/CNetIf.h#L73

in Arduino's Mbed Core my PR with this was already merged. arduino/ArduinoCore-mbed#776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet