add Stream::readStringUntil function that uses string terminator #9011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is not a breaking change and does not override the Arduino API, so looks good. |
yes |
|
Can you please add a comment or rename the variable ? |
done |
d-a-v
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Approving: Next step is to simplify our calls to readStringUntil() from our libraries (especially but not only parsing-impl.h)
edit (or improve Stream::sendUntil() with this same new API) - see #9005)
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
…8266#9011) * add readStringUntil function with string terminator * rename count parameter to untilTotalNumberOfOccurrences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently there is a
function, but there is no equivalent of it that uses string terminator. this pr implements
i found this useful for small html parsing or truncating.