#include <exception> for a direct dependency
#8978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems fine, but using exceptions unpatched from a generic GCC will result in the exception unwind tables living in RAM. It'll work, but you're going to spend a large portion of usable RAM on them. See the esp-quick-toolchain for some patches against the current GCC. -edit- Actually, you may be OK. The linker will place the unwind tables in flash and if you use the unaligned read exception code (slow, but works) it might just be fine. If you don't then the unwinder will attempt to do byte-wide accesses to those tables ruining your day. |
mcspr
changed the title
#include <exception> for a direct dependency
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
I was recently trying to compile this project with a more recent version of GCC and hit an issue with this file. With older versions the std::set_terminate definition was being included via a transitive include of <exception> from the C++ standard library implementation. This is no longer the case with newer versions of libstdc++. This fixes the issue by using a direct include instead of relying on an implementation specific transitive include.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently trying to compile this project with a more recent version of GCC and hit an issue with this file. With older versions the
std::set_terminatedefinition was being included via a transitive include of<exception>from the C++ standard library implementation. This is no longer the case with newer versions oflibstdc++. This fixes the issue by using a direct include instead of relying on an implementation specific transitive include.