Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build containers for iperf with github actions #1763

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kashalls
Copy link

PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":

You are under no obligation whatsoever to provide any bug fixes, patches, or
upgrades to the features, functionality or performance of the source code
("Enhancements") to anyone; however, if you choose to make your Enhancements
available either publicly, or directly to Lawrence Berkeley National
Laboratory, without imposing a separate written license agreement for such
Enhancements, then you hereby grant the following license: a non-exclusive,
royalty-free perpetual license to install, use, modify, prepare derivative
works, incorporate into other computer software, distribute, and sublicense
such enhancements or derivative works thereof, in binary and source code form.

The complete iperf3 license is available in the LICENSE file in the
top directory of the iperf3 source tree.

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies: master

  • Issues fixed (if any): (See brief description)

  • Brief description of code changes (suitable for use as a commit message):

Adds automation to expand on pre-existing Dockerfile. It builds and deploys the container to ghcr.io/esnet/iperf.

@kashalls
Copy link
Author

My intention for this feature was to setup some kind of "official" implementation of an iperf container.

A Dockerfile as added to /contrib in #824 which functions as a minimal docker container. This hasn't been updated and does not build the binary. This change builds iperf and puts it into a container that defaults to server mode.

If you go to docker hub, there are almost 1,400 different containers that have been pushed once and never again. There is no telling what those containers actually run unless you look into it. What individual is going to look through 1,400 containers.
BiT64tr

Publishing this container, automatically, will allow users who only want to run trusted containers an option instead of having to build, maintain and deploy forks.

@userdocs
Copy link

I do something similar here but I use Alpine Linux and target more architectures + windows x86_64 builds.

https://github.com/userdocs/iperf3-static

docker run -it ghcr.io/userdocs/iperf3-static:latest iperf3 --version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants