ISSUE-445: Fragment not respected when async/manifest driven mode is present #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from the hash But ... Sometimes, race condition? (something outside of our code) reset the URL removing the hashes. It still works, searches, etc from a passed url, but the reset happens after processSearchResults() is triggered. I can't sleep until this is exactly working as before... @alliomeria
DiegoPino
added
bug
|
This will have to go into 1.5.0. Only I tested this, so not 100% accurate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #445
This is WIP. It does fix the actual problem but in some occasions (*when the results come back too fast?) the internal Bookreader logic resets the URL, so people could loose the ability of bookmarking. The code works but that is annoying. I need to find the culprit somewhere still
@alliomeria @patdunlavey