Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use eslint-plugin-eslint-plugin #64

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Enables eslint-plugin-eslint-plugin for linting rules and rule tests.

What changes did you make? (Give an overview)

Added eslint-plugin-eslint-plugin dev dependency and enabled rules in the eslint config.

Related Issues

Is there anything you'd like reviewers to focus on?

Config is the same as in eslint/eslint repo, except for:

  • eslint-plugin/require-meta-schema is disabled. In ESLint v9, schema defaults to [], so I think this rule isn't necessary, and we don't have schema: [] in this plugin's rules.
  • eslint-plugin/require-meta-docs-url is disabled as this plugin's rules don't have this property set (though it might be good to add URLs to rule docs on GitHub).
  • eslint-plugin/test-case-property-ordering has "language" added.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit ede448d into main Nov 21, 2024
15 checks passed
@nzakas nzakas deleted the eslint-plugin-eslint-plugin branch November 21, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants