fix: Don't deploy future blog posts in production #646
Conversation
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| module.exports = collection => { | ||
| let now = new Date(); | ||
| const CONTEXT = process.env.CONTEXT; | ||
| const showFuturePostsAndDrafts = !CONTEXT || CONTEXT === "deploy-preview"; | ||
| const showDrafts = !CONTEXT || CONTEXT === "deploy-preview"; |
There was a problem hiding this comment.
Just to clarify: this no longer affects future posts?
There was a problem hiding this comment.
Yes, this code doesn't filter out future posts from https://eslint.org/blog/ anymore because the new code in .eleventy.js already filters out them from everywhere under the same conditions, so I just removed the now-unnecessary code from here.
Prerequisites checklist
What is the purpose of this pull request?
A future blog post is a blog post with a publication date > current date. Those posts shouldn't appear on the site before their publication date.
Currently, if we have a future blog post merged, it indeed wouldn't appear in the list of blog posts on https://eslint.org/blog/. But it's still rendered, deployed, can be accessed, and appears in the sitemap and in the list of blog posts on its category page (e.g., https://eslint.org/blog/category/case-studies/).
What changes did you make? (Give an overview)
Updated
.eleventy.jsto completely ignore future blog posts, so they won't be rendered and deployed.Related Issues
#645 (comment)
Is there anything you'd like reviewers to focus on?