feat: add EOF banner #609
feat: add EOF banner #609
Conversation
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| a { | ||
| color: var(--body-background-color); | ||
| padding: 0 4px; |
There was a problem hiding this comment.
I don't think you would need padding to anchor element if you were using <p> tag for content? It would preserve white space for you?
There was a problem hiding this comment.
Yes, we can use the p tag and remove the margin. However, in the mobile view, the text jumps to a new line because the p tag uses the display: block property.
|
Thanks for putting this together. It looks like the hourglass is aligned to the text baseline, but it should be vertically centered in the banner. It appears there may be some extra space at the bottom of the hour glass? We had decided not to use the bright purple banner as it was too aggressive. We were going to use the gray in option 1 of this comment. "Long-term support options" should link to /version-support. I would also adjust the text in the banner to read:
|
Co-authored-by: Nicholas C. Zakas <[email protected]>
Co-authored-by: 唯然 <[email protected]>
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Added EOL banner. (Addressed point no. 1 #594 (comment))
Related Issues
#594
Is there anything you'd like reviewers to focus on?
1. banner colour option selection for both dark and light themes.2. which link should be associated with the "long-term support" option text?