Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate configs list with eslint-doc-generator #146

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

bmish
Copy link
Member

@bmish bmish commented Dec 9, 2023

This new feature ensures that all the configs are listed in the readme, with the same emojis as used in the rules list.

Config descriptions aren't defined inside the configs themselves pending this issue:

@bmish bmish marked this pull request as draft December 9, 2023 18:16
@bmish bmish force-pushed the edg-auto-config-list branch from 2b6b7b8 to 990b537 Compare December 15, 2023 17:21
@bmish bmish force-pushed the edg-auto-config-list branch from 990b537 to 339bc56 Compare December 15, 2023 17:23
@bmish bmish marked this pull request as ready for review December 15, 2023 17:25
@bmish
Copy link
Member Author

bmish commented Dec 15, 2023

@aladdin-add I moved the descriptions out of the configs themselves to unblock this PR.

Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 Looks good to me

Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 6409e34 into eslint-community:master Dec 16, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants