Skip to content

Commit

Permalink
feat: Add syntax check for ES2021 to no-unsupported-features/es-synta…
Browse files Browse the repository at this point in the history 
…x rule (#152)

the change was borrowed from mysticatea#283
credits goes to @ota-meshi
  • Loading branch information
@aladdin-add
aladdin-add authored Dec 20, 2023
1 parent 6409e34 commit 6835a10
Show file tree
Hide file tree
Showing 3 changed files with 129 additions and 8 deletions.
30 changes: 30 additions & 0 deletions lib/rules/no-unsupported-features/es-syntax.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,28 @@ const features = {
},
],
},

//--------------------------------------------------------------------------
// ES2021
//--------------------------------------------------------------------------
logicalAssignmentOperators: {
ruleId: "no-logical-assignment-operators",
cases: [
{
supported: "15.0.0",
messageId: "no-logical-assignment-operators",
},
],
},
numericSeparators: {
ruleId: "no-numeric-separators",
cases: [
{
supported: "12.5.0",
messageId: "no-numeric-separators",
},
],
},
}
const keywords = Object.keys(features)

Expand Down Expand Up @@ -654,6 +676,14 @@ module.exports = {
"Optional chainings are not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",
"no-nullish-coalescing-operators":
"Nullish coalescing operators are not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",

//------------------------------------------------------------------
// ES2021
//------------------------------------------------------------------
"no-logical-assignment-operators":
"Logical assignment operators are not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",
"no-numeric-separators":
"Numeric separators are not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",
},
},
create(context) {
Expand Down
2 changes: 0 additions & 2 deletions tests/lib/rules/no-path-concat.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -169,5 +169,3 @@ new RuleTester({
},
],
})

/*eslint-enable no-template-curly-in-string */
105 changes: 99 additions & 6 deletions tests/lib/rules/no-unsupported-features/es-syntax.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,19 @@ const { builtin } = require("globals")
const { Range } = require("semver")
const rule = require("../../../../lib/rules/no-unsupported-features/es-syntax")

const ES2020Supported = (() => {
const config = { parserOptions: { ecmaVersion: 2020 } }
const ES2021Supported = (() => {
const config = { parserOptions: { ecmaVersion: 2021 } }
const messages = new Linter().verify("0n", config)
return messages.length === 0
})()
const ecmaVersion = ES2020Supported ? 2020 : 2019
const ES2020Supported =
ES2021Supported ||
(() => {
const config = { parserOptions: { ecmaVersion: 2020 } }
const messages = new Linter().verify("0n", config)
return messages.length === 0
})()
const ecmaVersion = ES2021Supported ? 2021 : ES2020Supported ? 2020 : 2019

/**
* Makes a file path to a fixture.
Expand Down Expand Up @@ -1553,7 +1560,6 @@ ruleTester.run(
],
},
],
/*eslint-enable no-template-curly-in-string */
},
{
keyword: "unicodeCodePointEscapes",
Expand Down Expand Up @@ -2592,6 +2598,93 @@ ruleTester.run(
],
},

//----------------------------------------------------------------------
// ES2021
//----------------------------------------------------------------------
{
keyword: "logicalAssignmentOperators",
requiredEcmaVersion: 2021,
valid: [
{
code: "a ||= b",
options: [{ version: "15.0.0" }],
},
{
code: "a &&= b",
options: [{ version: "15.0.0" }],
},
{
code: "a ??= b",
options: [{ version: "15.0.0" }],
},
],
invalid: [
{
code: "a ||= b",
options: [{ version: "14.0.0" }],
errors: [
{
messageId: "no-logical-assignment-operators",
data: {
supported: "15.0.0",
version: "14.0.0",
},
},
],
},
{
code: "a &&= b",
options: [{ version: "14.0.0" }],
errors: [
{
messageId: "no-logical-assignment-operators",
data: {
supported: "15.0.0",
version: "14.0.0",
},
},
],
},
{
code: "a ??= b",
options: [{ version: "14.0.0" }],
errors: [
{
messageId: "no-logical-assignment-operators",
data: {
supported: "15.0.0",
version: "14.0.0",
},
},
],
},
],
},
{
keyword: "numericSeparators",
requiredEcmaVersion: 2021,
valid: [
{
code: "a = 123_456_789",
options: [{ version: "12.5.0" }],
},
],
invalid: [
{
code: "a = 123_456_789",
options: [{ version: "12.4.0" }],
errors: [
{
messageId: "no-numeric-separators",
data: {
supported: "12.5.0",
version: "12.4.0",
},
},
],
},
],
},
//----------------------------------------------------------------------
// MISC
//----------------------------------------------------------------------
Expand Down Expand Up @@ -2663,7 +2756,7 @@ ruleTester.run(
{
filename: fixture("invalid/a.js"),
code: "var a = { ...obj }",
options: [{version: '>=8.0.0'}],
options: [{ version: ">=8.0.0" }],
errors: [
{
messageId: "no-rest-spread-properties",
Expand All @@ -2684,7 +2777,7 @@ ruleTester.run(
{
filename: fixture("nothing/a.js"),
code: "var a = { ...obj }",
options: [{version: '>=8.0.0'}],
options: [{ version: ">=8.0.0" }],
errors: [
{
messageId: "no-rest-spread-properties",
Expand Down

0 comments on commit 6835a10

Please sign in to comment.