chore: move rule tests parserOptions to ruleTester

it can help migrating to the eslint v9 RuleTester
eslint-community · Jan 3, 2024 · 4755533 · 4755533
1 parent bc6c538
commit 4755533
Show file tree

Hide file tree

Showing 33 changed files with 352 additions and 708 deletions.
diff --git a/package.json b/package.json
@@ -31,10 +31,10 @@
         "@types/eslint": "^8.44.6",
         "@typescript-eslint/parser": "^5.60.0",
         "esbuild": "^0.18.7",
-        "eslint": "^8.53.0",
+        "eslint": "^8.56.0",
         "eslint-config-prettier": "^8.8.0",
         "eslint-doc-generator": "^1.6.1",
-        "eslint-plugin-eslint-plugin": "^5.1.0",
+        "eslint-plugin-eslint-plugin": "^5.2.1",
         "eslint-plugin-n": "file:.",
         "fast-glob": "^3.2.12",
         "husky": "^8.0.3",

diff --git a/tests/lib/rules/callback-return.js b/tests/lib/rules/callback-return.js
@@ -6,8 +6,9 @@
 
 const RuleTester = require("eslint").RuleTester
 const rule = require("../../../lib/rules/callback-return")
+const ruleTester = new RuleTester({ env: { node: true, es6: true } })
 
-new RuleTester().run("callback-return", rule, {
+ruleTester.run("callback-return", rule, {
     valid: [
         // callbacks inside of functions should return
         "function a(err) { if (err) return callback (err); }",
@@ -40,25 +41,20 @@ new RuleTester().run("callback-return", rule, {
         // arrow functions
         {
             code: "var x = err => { if (err) { callback(); return; } }",
-            parserOptions: { ecmaVersion: 6 },
         },
         {
             code: "var x = err => callback(err)",
-            parserOptions: { ecmaVersion: 6 },
         },
         {
             code: "var x = err => { setTimeout( () => { callback(); }); }",
-            parserOptions: { ecmaVersion: 6 },
         },
 
         // classes
         {
             code: "class x { horse() { callback(); } } ",
-            parserOptions: { ecmaVersion: 6 },
         },
         {
             code: "class x { horse() { if (err) { return callback(); } callback(); } } ",
-            parserOptions: { ecmaVersion: 6 },
         },
 
         // options (only warns with the correct callback name)
@@ -188,7 +184,6 @@ new RuleTester().run("callback-return", rule, {
         },
         {
             code: "var x = (err) => { if (err) { callback (err); } }",
-            parserOptions: { ecmaVersion: 6 },
             errors: [
                 {
                     messageId: "missingReturn",
@@ -200,7 +195,6 @@ new RuleTester().run("callback-return", rule, {
         },
         {
             code: "var x = { x(err) { if (err) { callback (err); } } }",
-            parserOptions: { ecmaVersion: 6 },
             errors: [
                 {
                     messageId: "missingReturn",
@@ -223,7 +217,6 @@ new RuleTester().run("callback-return", rule, {
         },
         {
             code: "var x = { x(err) { if (err) { callback && callback (err); } } }",
-            parserOptions: { ecmaVersion: 6 },
             errors: [
                 {
                     messageId: "missingReturn",
@@ -268,7 +261,6 @@ new RuleTester().run("callback-return", rule, {
         },
         {
             code: "var a = (err) => { callback (err); callback(); }",
-            parserOptions: { ecmaVersion: 6 },
             errors: [
                 {
                     messageId: "missingReturn",
@@ -302,7 +294,6 @@ new RuleTester().run("callback-return", rule, {
         },
         {
             code: "class x { horse() { if (err) { callback(); } callback(); } } ",
-            parserOptions: { ecmaVersion: 6 },
             errors: [
                 {
                     messageId: "missingReturn",
@@ -344,7 +335,6 @@ new RuleTester().run("callback-return", rule, {
         },
         {
             code: "() => { if (x) { callback(); } }",
-            parserOptions: { ecmaVersion: 6 },
             errors: [
                 {
                     messageId: "missingReturn",