Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unflake thedropped_client_doesnt_create_duplicate_carbons test #4437

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Unflake thedropped_client_doesnt_create_duplicate_carbons test #4437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion big_tests/tests/carboncopy_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,20 @@ dropped_client_doesnt_create_duplicate_carbons(Config) ->
fun(Alice1, Alice2, Bob) ->
enable_carbons([Alice1, Alice2]),
Msg = escalus_stanza:chat_to(Bob, ?BODY),
C2SPid = mongoose_helper:get_session_pid(Alice2),
escalus_client:stop(Config, Alice2),
escalus:assert(is_presence_with_type, [<<"unavailable">>],
escalus_client:wait_for_stanza(Alice1)),
%% Ensure there is no session so that the test doesn't flake and fail by chance.
%% The issue comes from the fact that mod_presence sends the "unavailable" stanza
%% just before removing the is removed from ejabberd_sm. If the msg is received by
%% mod_carboncopy in this short window, it still considers the resource enabled.
%% It's a race condition, but from the user's perspective it shouldn't be a big issue.
mongoose_helper:wait_for_pid_to_die(C2SPid),
Comment on lines +183 to +192
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fine one, we've used this trick to ensure we wait for the pid to die many other times 👌🏽

escalus_client:send(Alice1, Msg),
escalus:assert(is_chat_message, [?BODY],
escalus_client:wait_for_stanza(Bob)),
[] = escalus_client:peek_stanzas(Alice1)
escalus_assert:has_no_stanzas(Alice1)
end).

prop_forward_received_chat_messages(Config) ->
Expand Down