-
Notifications
You must be signed in to change notification settings - Fork 429
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not persist credentials on GH Actions
I ran a GH Actions safety checker, which suggested that the "persist-credentials" option should be set to "false". The rationale: https://woodruffw.github.io/zizmor/audits/#artipacked. It is not a big issue for us, as we don't upload artifacts from GH Actions, but using this option should add a bit of safety anyway.
- Loading branch information
1 parent
91cdfa1
commit 7241910
Showing
1 changed file
with
7 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,7 @@ jobs: | |
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
persist-credentials: false | ||
- uses: erlef/[email protected] | ||
with: | ||
otp-version: ${{ matrix.otp }} | ||
|
@@ -82,6 +83,7 @@ jobs: | |
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
persist-credentials: false | ||
- uses: ./.github/actions/big-tests | ||
with: | ||
otp: ${{matrix.otp}} | ||
|
@@ -112,6 +114,7 @@ jobs: | |
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
persist-credentials: false | ||
- uses: ./.github/actions/big-tests | ||
with: | ||
otp: ${{matrix.otp}} | ||
|
@@ -146,6 +149,7 @@ jobs: | |
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
persist-credentials: false | ||
- uses: erlef/[email protected] | ||
with: | ||
otp-version: ${{matrix.otp}} | ||
|
@@ -162,6 +166,7 @@ jobs: | |
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
persist-credentials: false | ||
- uses: erlef/[email protected] | ||
with: | ||
otp-version: ${{matrix.otp}} | ||
|
@@ -178,6 +183,7 @@ jobs: | |
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
persist-credentials: false | ||
- uses: erlef/[email protected] | ||
with: | ||
otp-version: ${{matrix.otp}} | ||
|
@@ -200,4 +206,5 @@ jobs: | |
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
persist-credentials: false | ||
- run: tools/test.sh -p pkg |