Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated README and added some shell utils #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated README and added some shell utils #82

wants to merge 2 commits into from

Conversation

cyruseuros
Copy link

I can split this into 2 PRs if you prefer it that way.

@esjeon
Copy link
Owner

esjeon commented May 6, 2020

Thanks for the PR. Here are my thoughts:

  1. Maybe we can split the script into a new file or a gist, and provide its URL in README? I think the script is too big to be included.

  2. This part is a bit confusing:

    draw borders on maximized windows. Sometimes windows are not in "monocle mode" as far as Krohkite is concerned, are maximized as far as KDE is concerned, and KDE does not draw borders on maximized windows by default.

    How about the one below?

    prevent borders from disappearing. When a window is marked "maximized" in Breeze theme, its borders are removed to save screen space. This behavior may not be preferable depending on your setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyruseuros @esjeon