fix type warnings with strict gcc #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
approved these changes
Jun 10, 2024
beckermr
reviewed
Jun 10, 2024
fitsio/fitsio_pywrap.c
Outdated
Comment on lines
3606
to
3629
| PyObject* columnsobj=NULL; | ||
| PyObject* array=NULL; | ||
|
|
||
| PyObject* rowsObj=NULL; | ||
| PyObject* sortindObj=NULL; | ||
| PyObject *columns_obj, *array_obj, *rows_obj, *sortind_obj; |
There was a problem hiding this comment.
Did we want to get rid of the NULL initialization here?
There was a problem hiding this comment.
They are immediately read into by the module initialization, so its OK in this case. I did it for readability. But if you don't like I'm happy to set NULL
There was a problem hiding this comment.
by module init I meant things like PyArg_ParseTuple
There was a problem hiding this comment.
Never mind, I'll just set NULL
There was a problem hiding this comment.
Right I don't care, I just wanted to flag it.
beckermr
reviewed
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.