Validate UoE emails #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjin96
approved these changes
Dec 13, 2024
| @@ -17,7 +17,6 @@ | |||
|
|
|||
| data_re = re.compile('[ a-zA-Z0-9_@.+-]*') | |||
|
|
|||
|
|
|||
| @@ -5,6 +5,12 @@ | |||
| from home.models import Point, WgUpdate, Minutes | |||
| from users.models import Profile | |||
|
|
|||
| def validate_uoe_mail(value): | |||
There was a problem hiding this comment.
is_university_email or similar might be more intuitive naming, e.g. leads to if not is_university_email() ....
| @@ -5,6 +5,12 @@ | |||
| from home.models import Point, WgUpdate, Minutes | |||
| from users.models import Profile | |||
|
|
|||
| def validate_uoe_mail(value): | |||
| if "ac.uk" in value: | |||
There was a problem hiding this comment.
More of an edge case, but if value.endswith('ac.uk') might be better in case some one with an email similar to [email protected] will be able to sign up.
In case you change this just a heads up if value.endswith('ac.uk') will crash if value is None but I assume that can't happen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple check to filter out UoE email addresses during applications