Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sin() function based on QD's implementation #1

Open
wants to merge 137 commits into
base: main
Choose a base branch
from
Open

Adding sin() function based on QD's implementation #1

wants to merge 137 commits into from
+465 −21

Conversation

L30nardoSV
Copy link
Member

The sin() function in this PR is based on that in https://github.com/scibuilder/QD.

Tests are passing partly. I think there is still room for improvement, so any feedback is welcome.

@L30nardoSV
Commenting out Doxygen generation in CMakeLists.txt.
decdb4b
@L30nardoSV
Starting to implement two<T> sin().
5cee964
@L30nardoSV
For single-precision: reduce the number of precised decimal digits do…
08aa749 
…wn to 7.
@L30nardoSV
Adding implementation of nint().
56f722f
@L30nardoSV
Adding reference implementation.
495a23a
@L30nardoSV
Parameterizing nint()'s implementation + extra statements.
a976da8
@L30nardoSV
Adding definition of <q>.
4ebf104
@L30nardoSV
Adding definition of <t>.
97ca2b9
@L30nardoSV
Adding missing ;
718f62d
@L30nardoSV
Recalculation of <q>.
ec98814
@L30nardoSV
Definitions of <k> and <abs_k>.
fc9fd58
@L30nardoSV
Adding conditional possibly returning nan.
06b7948
@L30nardoSV
Adding conditional (related to pi/16) possibly returning nan.
6f0061b
@L30nardoSV
Starting incorporating sin_taylor().
5f7543d
@L30nardoSV
Adding prototype for sqr().
f3d34f4
@L30nardoSV
Adding implementation of two_sqr(). Missing implementation of split().
b347a47
@L30nardoSV
Adding split() function signature.
959e99a
@L30nardoSV
Adding split() implementation.
3c8c66d
@L30nardoSV
More implementation of sqr() untill call to quick_two_sum().
bf73600
@L30nardoSV
Implementation of quick_two_sum().
91e42bb
@L30nardoSV
Completing sqr() implementation.
a868ea1
@L30nardoSV
Extra statements.
e63594a
@L30nardoSV
Completing preliminary implementation of sin_taylor().
7e240cd
@L30nardoSV
Starting to incorporate cos_taylor() implementation.
ce04319
@L30nardoSV
Minor fix.
1cb051c
@L30nardoSV
Adding implementation of mul_pwr2().
69d44d3
@L30nardoSV
Completing implementation of cos_taylor().
f6e9e58
@L30nardoSV
More of sin().
53f11cf
@L30nardoSV
Adding sin and cos tables for sin() implementation.
8140ec2
@L30nardoSV
Adding implementation of sincos_taylor().
0a3bd0d
@L30nardoSV
Removing definition and replacing invocations of to_double(A) with A.…
3dd021e 
…eval().
@L30nardoSV
Commenting out unnecessarily compute-intensive assignments to 0.0.
c29ad7b
@L30nardoSV
Removing commented-out code from previous commit.
28d95dd
@L30nardoSV
Replacing fp32/fp64_sin_table and cos_table with templated struct mem…
97a9980 
…bers.
@L30nardoSV
Moving inv_factor into templated struct.
29d8359
@L30nardoSV
Templating 2pi constant.
652ccf2
@L30nardoSV
Templating pi2.
80d36af
@L30nardoSV
Templating pi16.
dcfc61f
@L30nardoSV
Templating nan.
ed16c79
@L30nardoSV
Templating eps.
5d3de1c
@L30nardoSV
Removing unnecessary constants.
6efcb93
@L30nardoSV
Compacting code.
3b3ab43
@L30nardoSV
Renaming struct.
e48dc0d
@L30nardoSV
Defining and using templated variable pointfive.
3ffd66c
@L30nardoSV
Defining and using templated variable twopointzero.
800b777
@L30nardoSV
Defining and using templated variable zeropointzero.
aaf8057
@L30nardoSV
Defining and using templated variable onepointzero.
9e1e0be
@L30nardoSV
Moving definition of nint() outside qd namespace. Note that nint() is…
8b940f4 
… now overloaded.
@L30nardoSV
Moving definition of two_sqr() outside qd namespace.
2d7c5e4
@L30nardoSV
Moving definition of two_sum() outside qd namespace.
84ef266
@L30nardoSV
Additional comment.
ab0c884
@L30nardoSV
Moving definition of sqr() outside dd_real namespace.
50b5eda
@L30nardoSV
Moving definition of add() outside dd_real namespace. Note that such …
2421180 
…add() is overloaded.
@L30nardoSV
Minor removals.
608bbda
@L30nardoSV
Cleaning up.
274696b
@L30nardoSV
Parameterizing the mode and useFMA for sin().
59e215d
@L30nardoSV
Minor cleanup.
912281b
@L30nardoSV
More clarifications.
abe7664
@L30nardoSV
Documenting with /// \brief as much as possible.
f1811d8
@L30nardoSV
Copy link
Member Author

@timnoack: most (if not all) above points have been addressed. Please check the code again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timnoack timnoack timnoack requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L30nardoSV @timnoack