Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: Update standard_error to use prim_tty nif #9116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

kernel: Update standard_error to use prim_tty nif #9116

wants to merge 3 commits into from

Commits on Nov 27, 2024

  1. kernel: Update standard_error to use prim_tty nif 

    The primary reason that we do this is to make writing to standard_error
as synchronous as possible. When using the fd driver the write was
done on an async thread, which meant that there was no simple way
to get an acknowledgement when the write had completed. Now that we
use a NIF we can much more easily get a check when the write is done
so that we know when io:format(standard_error, ...) has returned we
have also written to that fd.
    @garazdawi
    garazdawi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    3098166 View commit details
    Browse the repository at this point in the history

  2. fixup! kernel: Update standard_error to use prim_tty nif

    @garazdawi
    garazdawi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ad8176a View commit details
    Browse the repository at this point in the history

  3. kernel: Run prim_tty on_load handler manually 

    standard_error is started before the on_load handlers in init
are run, so prim_tty will not be completely loaded when running
in embedded mode. So we call it during init of prim_tty instead.
    @garazdawi
    garazdawi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ba6446b View commit details
    Browse the repository at this point in the history