Refactor ssh_cli to use prim_tty #8805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 3 files 88 suites 1h 21m 22s ⏱️ Results for commit 71c78ba. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
frazze-jobb
force-pushed
the
frazze/ssh/ssh_cli_use_prim_tty/OTP-19226
branch
from
3100387 to
82cedb7
Compare
frazze-jobb
force-pushed
the
frazze/ssh/ssh_cli_use_prim_tty/OTP-19226
branch
from
82cedb7 to
147f0d6
Compare
frazze-jobb
force-pushed
the
frazze/ssh/ssh_cli_use_prim_tty/OTP-19226
branch
from
c9961d6 to
07519c4
Compare
frazze-jobb
added
testing
frazze-jobb
force-pushed
the
frazze/ssh/ssh_cli_use_prim_tty/OTP-19226
branch
from
949f431 to
1efe40a
Compare
frazze-jobb
added
the
testing
frazze-jobb
force-pushed
the
frazze/ssh/ssh_cli_use_prim_tty/OTP-19226
branch
from
1efe40a to
71c78ba
Compare
garazdawi
reviewed
Oct 14, 2024
Comment on lines
+125
to
+136
| [shell_navigation, shell_multiline_navigation, | ||
| shell_multiline_prompt_ssh, | ||
| shell_xnfix, shell_delete, | ||
| shell_transpose, shell_search, shell_insert, | ||
| shell_update_window, | ||
| shell_small_window_multiline_navigation, | ||
| shell_huge_input, | ||
| shell_support_ansi_input, | ||
| shell_receive_standard_out, | ||
| shell_expand_location_above, | ||
| shell_expand_location_below, | ||
| shell_clear]}, |
There was a problem hiding this comment.
I wonder if perhaps we should move the tests that are common to both tty and shell to a separate function, or maybe a separate group? So that it is natural to add tests in both categories when adding new testcases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors ssh_cli to use prim_tty instead of its own thing.
Adds tests in interactive_shell_SUITE to test that the ssh client behaves the same as the 'erl' shell.