Allow channel handler to control adjust_window message sending #8775
Conversation
CT Test Results 2 files 29 suites 19m 24s ⏱️ Results for commit f2389c3. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
you can ignore "unexpected event found" errors in ssh test results at this stage, they're probably unrelated. |
yarisx
force-pushed
the
ymaslenn/ssh_controlled_adjust
branch
from
473af79
to
9826e65
Compare
|
Rebased to the latest master, hope that makes test failures go away. |
yarisx
force-pushed
the
ymaslenn/ssh_controlled_adjust
branch
from
9826e65
to
91e71a9
Compare
|
sorry for delay. please convert draft into PR. I think this is a wanted feature but we need to discuss some details:
|
The channel handler callback module can implement the window_handling_mode/0 function returning either 'auto' or 'manual' values. In the latter case the channel handler module is responsible for invoking ssh_connection:adjust_window/3 to send ssh_msg_adjust_window to the peer.
yarisx
force-pushed
the
ymaslenn/ssh_controlled_adjust
branch
from
91e71a9
to
3aaf55a
Compare
|
I've changed the implementation because the initial code did not cover the case when clients do not utilize |
| @@ -231,12 +235,25 @@ end_per_group(_, Config) -> | |||
| Config. | |||
|
|
|||
| %%-------------------------------------------------------------------- | |||
| init_per_testcase(_TestCase, Config) -> | |||
| init_per_testcase(TestCase, Config) -> | |||
| io:format(user, "Testcase ~p~n", [TestCase]), | |||
There was a problem hiding this comment.
please remove io:format above, or replace with ct:log if you prefer.
The channel handler callback module can implement the get_adjust/0 function returning either 'immediate' or 'delayed' values.
In the latter case the channel handler module is responsible for invoking ssh_connection:adjust_window/3 to send ssh_msg_adjust_window to the peer.