headerdownload: handle tie breaker for forkchoice in pow networks #8616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manav2401
commented
Oct 30, 2023
| if td.Cmp(hi.localTd) >= 0 { | ||
| reorg := true | ||
|
|
||
| // TODO: Add bor check here if required |
There was a problem hiding this comment.
This is something which I am not sure of. If no other chain is using the PoW flow, I think we don't need to wrap this with isBor check. If not, we might have to change the function signature for checking if we're running bor.
There was a problem hiding this comment.
This PoW flow is only used for Polygon.
yperbasis
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on maticnetwork/bor#871 in bor, this PR handles import of same difficulty chains (tie breaker conditions) based on their height and hash.
This PR also modifies an existing test to check different types of side-chain import and how the canonical is decided.