e3: reduce size of domain/hist/ii files. remove history concept from api. #12621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awskii
approved these changes
Nov 6, 2024
AskAlexSharov
changed the title
AskAlexSharov
added a commit
that referenced
this pull request
Nov 16, 2024
Rename: - `DomainRange` to `RangeAsOf` - `DomainGetAsOf` to `GetAsOf` - `DomainGet` to `GetLatest` all this methods do accept typed `kv.Domain` as a parameter merge after #12621
This was referenced Nov 16, 2024
AskAlexSharov
added a commit
that referenced
this pull request
Nov 17, 2024
Rename: - `DomainRange` to `RangeAsOf` - `DomainGetAsOf` to `GetAsOf` - `DomainGet` to `GetLatest` all this methods do accept typed `kv.Domain` as a parameter merge after #12621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we decided to not expose
Historyconcept to users:HistoryRangeandHistorySeekmethods to acceptdomain. remove concept of standalone history (and their names).Reduce size of
domain.go/history.go/inverted_index.go:move streams to own files
use same
scanDirtyfuncremove
DomainStats- unused