Skip to content

Commit

Permalink
Switch to dynamically linked binaries in goreleaser (#12795)
Browse files Browse the repository at this point in the history
The released binaries of erigon3-alpha5 have cross-compatibility issues
as demonstrated here:

#12556
#12570

The reason for this was the static linking of system libraries which may
not work correctly in other operating systems (e.g. Arch Linux).

This problem can be averted by producing a dynamically linked binary
instead, and assume that the user has correctly working system library
dependencies.

---------

Co-authored-by: antonis19 <[email protected]>
  • Loading branch information
antonis19 and antonis19 authored Nov 20, 2024
1 parent ffcbbf1 commit 8c9cfc2
Show file tree
Hide file tree
Showing 3 changed files with 63 additions and 63 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci-cd-main-branch-docker-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
-v ${HOME}/go/pkg/mod:/go/pkg/mod \
-w /erigon --entrypoint /bin/sh \
${{ env.BUILDER_IMAGE }} \
-c "apk update; apk add make git gcc libstdc++ build-base linux-headers bash ca-certificates; git config --global --add safe.directory /erigon; make GOARCH=arm64 GOBIN=/erigon-build BUILD_TAGS=nosqlite,noboltdb,nosilkworm,netgo erigon integration rpcdaemon"
-c "apk update; apk add make git gcc libstdc++ build-base linux-headers bash ca-certificates; git config --global --add safe.directory /erigon; make GOARCH=arm64 GOBIN=/erigon-build BUILD_TAGS=nosqlite,noboltdb,nosilkworm erigon integration rpcdaemon"
- name: Build amd64
run: |
Expand All @@ -94,7 +94,7 @@ jobs:
-v ${HOME}/go/pkg/mod:/go/pkg/mod \
-w /erigon --entrypoint /bin/sh \
${{ env.BUILDER_IMAGE }} \
-c "apk update; apk add make git gcc libstdc++ build-base linux-headers bash ca-certificates; git config --global --add safe.directory /erigon; make GOARCH=amd64 GOAMD64=v2 GOBIN=/erigon-build BUILD_TAGS=nosqlite,noboltdb,nosilkworm,netgo erigon integration rpcdaemon"
-c "apk update; apk add make git gcc libstdc++ build-base linux-headers bash ca-certificates; git config --global --add safe.directory /erigon; make GOARCH=amd64 GOAMD64=v2 GOBIN=/erigon-build BUILD_TAGS=nosqlite,noboltdb,nosilkworm erigon integration rpcdaemon"
- name: Build and push multi-platform docker image based on the commit id ${{ steps.getCommitId.outputs.short_commit_id }} in the main branch
env:
Expand Down
Loading

0 comments on commit 8c9cfc2

Please sign in to comment.