env: support underscore separated numbers (#12818)

erigon-lib/common/dbg/dbg_env.go

@@ -17,6 +17,7 @@
 package dbg
 
 import (
+	"fmt"
 	"os"
 	"strconv"
 	"strings"
@@ -70,20 +71,14 @@ func EnvInt(envVarName string, defaultVal int) int {
 	v, _ := os.LookupEnv(envVarName)
 	if v != "" {
 		WarnOnErigonPrefix(envVarName)
-		i, err := strconv.Atoi(v)
-		if err != nil {
-			panic(err)
-		}
+		i := MustParseInt(v)
 		log.Info("[env]", envVarName, i)
 		return i
 	}
 
 	v, _ = os.LookupEnv("ERIGON_" + envVarName)
 	if v != "" {
-		i, err := strconv.Atoi(v)
-		if err != nil {
-			panic(err)
-		}
+		i := MustParseInt(v)
 		log.Info("[env]", envVarName, i)
 		return i
 	}
@@ -141,3 +136,12 @@ func WarnOnErigonPrefix(envVarName string) {
 		log.Warn("[env] please use ERIGON_ prefix for env variables of erigon", "var", envVarName)
 	}
 }
+
+func MustParseInt(strNum string) int {
+	cleanNum := strings.ReplaceAll(strNum, "_", "")
+	parsed, err := strconv.ParseInt(cleanNum, 10, 64)
+	if err != nil {
+		panic(fmt.Errorf("%w, str: %s", err, strNum))
+	}
+	return int(parsed)
+}

erigon-lib/common/dbg/experiments.go

@@ -22,7 +22,6 @@ import (
 	"path/filepath"
 	"runtime"
 	"runtime/pprof"
-	"strconv"
 	"sync"
 	"time"
 
@@ -96,10 +95,7 @@ func DirtySpace() uint64 {
 	dirtySaceOnce.Do(func() {
 		v, _ := os.LookupEnv("MDBX_DIRTY_SPACE_MB")
 		if v != "" {
-			i, err := strconv.Atoi(v)
-			if err != nil {
-				panic(err)
-			}
+			i := MustParseInt(v)
 			log.Info("[Experiment]", "MDBX_DIRTY_SPACE_MB", i)
 			dirtySace = uint64(i * 1024 * 1024)
 		}