Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface artifacts through sidecar #2

Closed
wants to merge 294 commits into from
Closed

Surface artifacts through sidecar #2

wants to merge 294 commits into from

Conversation

ericzzzzzzz
Copy link
Owner

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Yongxuanzhang and others added 30 commits December 8, 2023 16:42
@Yongxuanzhang @tekton-robot
don't return validation error when final tasks failed/skipped
7c040de 
This commit closes tektoncd#6139, in previous fix PR:
tektoncd#6395, only dagTasks statuses
are considered and final tasks are missing. This PR fixes this.

Signed-off-by: Yongxuan Zhang [email protected]
@Yongxuanzhang @tekton-robot
change ResultRef.ResultsIndex from int to *int
f9737b2 
This commit closes 7392. When we introduced array results, we added
validation funciton to check if the result reference is out of the array
bound, in the cases of refercing a whole array and that array is empty, the resolved array index
is 0, so the validation will error. Since the resolved index is only
used when array indexing references exist, it is an optional field for
ResultRef so we should change it to a pointer.

Signed-off-by: Yongxuan Zhang [email protected]
@QuanZhang-William @tekton-robot
[TEP-0050] Add Ignore Task Failure to alpha table
368bb7e 
This commit adds "Ignore Task Failure" to the alpha feature table.

/kind documentation
@JeromeJu @tekton-robot
Fix: do not fail TaskRun for concurrent modification errors
fc02b29 
This commit fixes the behaviour that a concurrent modification error
when stopping sidecar will fail the TaskRun, which could cause
successful Tasks to fail even though it could succeed after retrying.

/kind bug
@chmouel @tekton-robot
Git resolver: validate repo URL
123a690 
Make sure the repo URL is a valid git, http or https URL

Signed-off-by: Chmouel Boudjnah <[email protected]>
@joaosilva15 @tekton-robot
FIX: Prevent panic on parameter evaluation
5c47c88 
Signed-off-by: Joao Pedro Silva <[email protected]>
@QuanZhang-William @tekton-robot
Fix enum validation with multiple param references
8e9fd46 
Fixes [tektoncd#7476][7476]. TEP-0144 requires that the pipeline-level `enum` must be a subset of referenced task-level `enum`.

Prior to this commit, the enum subset validation logic assumes that a task-level param only referenced only one pipeline-level `enum`,
and does not support scenario where multiple pipeline-level `enums` are referenced (e.g., "$(params.p1) and $(params.p2)").

This commit adds the handling logic for such compound references, skipping the subset validation in this scenario as there is no directly associated
params at pipeline level.

/kind bug

[7476]: tektoncd#7476
@chitrangpatel @tekton-robot
TEP-0142: Introduce WorkingDir in StepActions
5e3b0dc 
This PR introduces `workingDir` into `StepActions`. This allows
the `StepAction` to set the `workingDir` and work relative to it.
@dibyom @tekton-robot
[TEP-0131] Update Conformance Spec for v1 api types
e8d3bfd 
This commit updates the initial api spec from TEP-012 with changes from the
conformance policy defined in TEP-131 including:

- Using v1 resources instead of v1beta1 types
- Conformance specs for Tasks, Pipelines and PipelineRuns in addition to TaskRun
- Removes HTTP API requirement from conformance spec, instead the spec is defined in terms of JSON/YAML resources that can be consumed via an API
- The RECOMMENDED profile now includes support for taskRefs and pipelineRefs

Signed-off-by: Dibyo Mukherjee <[email protected]>
@chitrangpatel @tekton-robot
Freeze image sha for dind-sidecar example test.
7a9f4c3 
The example test examples/v1/taskruns/dind-sidecar.yaml has been failing in multiple PRs:
- tektoncd#7492 (comment)
- tektoncd#7494 (comment)
- tektoncd#7458 (comment)

That example has not been updated in a year. My guess is that the [new image](https://hub.docker.com/layers/library/docker/dind/images/sha256-e8c7a73504adaeff4bab939e8d1f18a6114c99c868b9203a66a42f25aa51e613?context=explore) which was released 16 hours ago (at this point) is causing this.

When the image is tagged to the previous version (`docker:24.0.6-dind`) in the taskrun yaml, it executes fine.
This PR updates the example test to use the sha256 of the previously
working image.This PR fixes tektoncd#7496.
@chmouel @tekton-robot
Fix step actions documentation
a7ab091 
It was referencing a TaskSpec in a task which would fail
@dependabot @tekton-robot
Bump github.com/spiffe/spire-api-sdk from 1.8.4 to 1.8.5
218b6b2 
Bumps [github.com/spiffe/spire-api-sdk](https://github.com/spiffe/spire-api-sdk) from 1.8.4 to 1.8.5.
- [Commits](spiffe/spire-api-sdk@v1.8.4...v1.8.5)

---
updated-dependencies:
- dependency-name: github.com/spiffe/spire-api-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@jerop @tekton-robot
Add stdoutConfig and stderrConfig to alpha features table
c43d040 
`stdoutConfig` and `stderrCon` are alpha features but they are not
in the alpha features table. This change adds these two features in
the table so that users are aware and maintainers can track progress
through the stability levels.

/kind documentation
@chmouel @tekton-robot
Fix showing error message when validation fail
36de579 
When step action is used in step, and feature flag is not enabled, the
error message is not shown correctly and would show a %s.

We are now using fmt.Sprintf to format the error message and show the
feature flag that need to be enabled properly. apis.ErrGeneric need a
empty string as second argument to be able to show the path steps so
adding this.

Fixes bug tektoncd#7493

Signed-off-by: Chmouel Boudjnah <[email protected]>
@JeromeJu @tekton-robot
Error sweep: complete user-facing error messages formats
e59ee42 
Prior to this commit, there are error inputs of PipelineRunStatus.MarkFailed
that do not fully comply with the 'MessageFormats'. This commit completes
the user facing error messages and adds the context to the ones that
were previously missing.

/kind cleanup
@JeromeJu @tekton-robot
Add back conversion for TaskRunStatus Resources
891bda9 
This commit adds back the conversion for TaskrunStatus resources which
are used by chains to sign outputs of image resources type. It also adds
back the conversion for TaskRun Resources.

/kind misc
fixes: tektoncd#7504
@dependabot @tekton-robot
Bump github.com/google/go-containerregistry from 0.16.1 to 0.17.0
6ab2cdf 
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.16.1 to 0.17.0.
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](google/go-containerregistry@v0.16.1...v0.17.0)

---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
Bump google.golang.org/grpc from 1.59.0 to 1.60.1
dbae089 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.59.0 to 1.60.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.59.0...v1.60.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
Bump github.com/jenkins-x/go-scm from 1.14.20 to 1.14.24
73317dd 
Bumps [github.com/jenkins-x/go-scm](https://github.com/jenkins-x/go-scm) from 1.14.20 to 1.14.24.
- [Release notes](https://github.com/jenkins-x/go-scm/releases)
- [Changelog](https://github.com/jenkins-x/go-scm/blob/main/CHANGELOG.md)
- [Commits](jenkins-x/go-scm@v1.14.20...v1.14.24)

---
updated-dependencies:
- dependency-name: github.com/jenkins-x/go-scm
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
Bump k8s.io/api in /test/custom-task-ctrls/wait-task-beta
7074360 
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.27.8 to 0.27.9.
- [Commits](kubernetes/api@v0.27.8...v0.27.9)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@vdemeester @tekton-robot
.github/workflows/woke.yml: set permissions to read-only
edb5782 
Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester @tekton-robot
.github/workflows/codeql-analysis.yml: set permissions to read-only
d543932 
Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester @tekton-robot
Hardened github action by using digest to reference them.
c21374c 
Dependabot will automatically update the digest **and** the version in
the comment.

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester @tekton-robot
Add a github action dependabot configuration
6cc2254 
Signed-off-by: Vincent Demeester <[email protected]>
@dependabot @tekton-robot
Bump ossf/scorecard-action from 2.1.2 to 2.3.1
8d02455 
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.2 to 2.3.1.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@e38b190...0864cf1)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
Bump github/codeql-action from 2.2.4 to 3.22.12
f121cda 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.4 to 3.22.12.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v2.2.4...012739e)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
Bump actions/upload-artifact from 3.1.0 to 4.0.0
0c83ddc 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.0 to 4.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@3cea537...c7d193f)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
Bump tj-actions/changed-files from 40.2.3 to 41.0.1
9a34499 
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40.2.3 to 41.0.1.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@56284d8...716b1e1)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
Bump actions/checkout from 3.1.0 to 4.1.1
281de9a 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.1.0...b4ffde6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@vdemeester @tekton-robot
Bump github.com/containerd/containerd from 1.7.8 to 1.7.11
8ad2da9 
The dependabot PR tektoncd#7521
updates other dependencies as well, this isolate the update.

Signed-off-by: Vincent Demeester <[email protected]>
JeromeJu and others added 22 commits April 12, 2024 18:13
@JeromeJu @tekton-robot
Init OSS Conformance Test Suite
094a5be 
This commit initiates the OSS conformance test suite. It sets the
standards for incrementing the V1 conformance test with the two simple
test cases.

/kind misc
@dependabot @tekton-robot
chore(deps): bump github.com/jenkins-x/go-scm from 1.14.29 to 1.14.30
0f2cc6e 
Bumps [github.com/jenkins-x/go-scm](https://github.com/jenkins-x/go-scm) from 1.14.29 to 1.14.30.
- [Release notes](https://github.com/jenkins-x/go-scm/releases)
- [Changelog](https://github.com/jenkins-x/go-scm/blob/main/CHANGELOG.md)
- [Commits](jenkins-x/go-scm@v1.14.29...v1.14.30)

---
updated-dependencies:
- dependency-name: github.com/jenkins-x/go-scm
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@skaegi @tekton-robot
Fix ImagePullTimeout to use "Initialized"
de643de 
ImagePullBackOffTimeOut currently uses the "Scheduled" pod condition transition time, however a pod can be scheduled on a node far earlier than when image pulling begins which can (and does) result in Tasks failing when image pulls could be retried and succeed.

We should use the transition time for "PodReadyToStartContainers" (1.29+) / "Initialized" for checking the image pull timeout as these conditions more accurately capture when the image pull began. This commit updates this logic and adds the covering tests.
@dependabot @tekton-robot
chore(deps): bump code.gitea.io/sdk/gitea from 0.17.1 to 0.18.0
9941454 
Bumps code.gitea.io/sdk/gitea from 0.17.1 to 0.18.0.

---
updated-dependencies:
- dependency-name: code.gitea.io/sdk/gitea
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
chore(deps): bump the all group in /tekton with 4 updates
d2f949b 
Bumps the all group in /tekton with 4 updates: chainguard/crane, chainguard/go, tekton-releases/dogfooding/ko and tekton-releases/dogfooding/koparse.


Updates `chainguard/crane` from `08a1fc1` to `931e19c`

Updates `chainguard/go` from `bedf4d9` to `1e9e266`

Updates `tekton-releases/dogfooding/ko` from `50712e3` to `e5296fb`

Updates `tekton-releases/dogfooding/koparse` from `cf7eb37` to `2eefe19`

---
updated-dependencies:
- dependency-name: chainguard/crane
  dependency-type: direct:production
  dependency-group: all
- dependency-name: chainguard/go
  dependency-type: direct:production
  dependency-group: all
- dependency-name: tekton-releases/dogfooding/ko
  dependency-type: direct:production
  dependency-group: all
- dependency-name: tekton-releases/dogfooding/koparse
  dependency-type: direct:production
  dependency-group: all
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
chore(deps): bump k8s.io/api in /test/custom-task-ctrls/wait-task-beta
9079ae9 
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.27.12 to 0.27.13.
- [Commits](kubernetes/api@v0.27.12...v0.27.13)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
chore(deps): bump github/codeql-action from 3.24.10 to 3.25.0
4fe52d4 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.10 to 3.25.0.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@4355270...df5a14d)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
chore(deps): bump github/codeql-action from 3.25.0 to 3.25.1
f671880 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.0 to 3.25.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@df5a14d...c7f9125)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
chore(deps): bump tj-actions/changed-files from 44.0.1 to 44.3.0
0a47cfe 
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 44.0.1 to 44.3.0.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@635f118...0874344)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
chore(deps): bump the all group in /tekton with 4 updates
c091595 
Bumps the all group in /tekton with 4 updates: chainguard/crane, chainguard/go, tekton-releases/dogfooding/ko and tekton-releases/dogfooding/koparse.


Updates `chainguard/crane` from `931e19c` to `a91db0e`

Updates `chainguard/go` from `1e9e266` to `7c09972`

Updates `tekton-releases/dogfooding/ko` from `e5296fb` to `78fc1bb`

Updates `tekton-releases/dogfooding/koparse` from `2eefe19` to `e2b95b5`

---
updated-dependencies:
- dependency-name: chainguard/crane
  dependency-type: direct:production
  dependency-group: all
- dependency-name: chainguard/go
  dependency-type: direct:production
  dependency-group: all
- dependency-name: tekton-releases/dogfooding/ko
  dependency-type: direct:production
  dependency-group: all
- dependency-name: tekton-releases/dogfooding/koparse
  dependency-type: direct:production
  dependency-group: all
...

Signed-off-by: dependabot[bot] <[email protected]>
@l-qing @tekton-robot
fix(docs): correct closing bracket in CEL expressions
f98ea63
@dependabot @tekton-robot
chore(deps): bump k8s.io/client-go
4578286 
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.27.11 to 0.27.13.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.27.11...v0.27.13)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
chore(deps): bump actions/upload-artifact from 4.3.1 to 4.3.3
382b234 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.1 to 4.3.3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@5d5d22a...6546280)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @tekton-robot
chore(deps): bump actions/checkout from 4.1.2 to 4.1.3
356b30d 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@9bb5618...1d96c77)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@khrm @tekton-robot
Add a feature flag to disable inline spec
b419b2c 
By default the inline specs will be enabled. Only if flag is set to
true, inline spec would be disabled. This is to increase security
of pipelines.
@afrittoli @tekton-robot
Fix the shell in crane image
faccef8 
The auth step in the publish task uses /busybox/sh in the crane
image but that does not exists anymore, switch to /bin/sh

Signed-off-by: Andrea Frittoli <[email protected]>
@l-qing @tekton-robot
fix: ensure default type for params in remote tasks to prevent pipeli…
30e389b 
…ne failures

fix tektoncd#7775

In the existing logic, resources used for ConvertTo should have default values set.
Otherwise, there could be issues with incorrect parameter types being set
(e.g., an array type being treated as a string type).

However, resources fetched from remote sources haven't undergone the SetDefaults
operation. If we directly invoke the ConvertTo operation, it might result in
erroneous outcomes.

For instance, a v1beta1 ClusterTask that undergoes a direct ConvertTo to convert
the resource into a v1 Task for validation might be mistakenly considered invalid.

Additionally, even if a v1beta1 Task passes validation, the process of converting
it to a v1 Task could still incorrectly set default parameter types, leading to
errors during execution.
@l-qing @tekton-robot
fix: do not set default kind when taskRef resolver is present
91bbee5 
fix tektoncd#7762

Do not set default kind when taskRef resolver is present,
keep the original configuration of the user.
@dependabot @tekton-robot
chore(deps): bump go.opentelemetry.io/otel/sdk from 1.25.0 to 1.26.0
b712fc5 
Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.25.0 to 1.26.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.25.0...v1.26.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@afrittoli @tekton-robot
Fix shell for tag-images step
fba68b7 
Fix the shell used in the tag-images script, part of the publish
task used for releases.

Signed-off-by: Andrea Frittoli <[email protected]>
@l-qing @tekton-robot
fix(taskrun): emit warning for missing secret in ServiceAccount inste…
a494d6a 
…ad of failing

fix tektoncd#7760

Log a warning if a Secrets in service account does not exist
@l-qing @tekton-robot
fix: resolve pod creation failure on retry when using `workspace.<nam…
e556bc7 
…e>.volume`

fix tektoncd#7886

Change the naming method of the workspace volume from completely random to
hashed, ensuring that the name generated during a single taskRun lifecycle is
consistent each time, and is unique within all current workspaces.

This way, we can reuse the logic of retrieving the taskSpec from the status,
and also store the content after variable expansion in the taskSpec of the
status for easy debugging; it will also not affect the reconstruction of the
pod when retrying.
@ericzzzzzzz ericzzzzzzz force-pushed the surface-artifacts-through-sidecar branch 3 times, most recently from bc59e03 to 1b04d6f Compare April 30, 2024 17:00
@ericzzzzzzz ericzzzzzzz force-pushed the surface-artifacts-through-sidecar branch 2 times, most recently from b86b023 to e684c6d Compare May 7, 2024 15:03
@ericzzzzzzz ericzzzzzzz force-pushed the surface-artifacts-through-sidecar branch from dc6c3f8 to 6c9e9b5 Compare May 7, 2024 17:01
@ericzzzzzzz ericzzzzzzz closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.