8.8.9 jp #98
Open
8.8.9 jp #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks without a problem in my installation -- otherwise it tried inserting text1,,text3 and that was an error in my sql version.
…auto increment so that will not be an issue anyway
…ase makes it not work when importing to external calendar programs, while a semi-colon (;) works. This is a workaround to deal with that.
AH01215: Using a hash as a reference is deprecated at ....
…e need to be able to use the localy defined .pm files
On any of the administration pages with new/delete/modify radio buttons (e.g. AdministerForm), our DocDB installation (DocDB 8.8.6) orders the radio buttons randomly. I don't think this can be intended behavior, and AuthorAdminDisable.js expects a consistent ordering of [new, delete, modify]. I think this is a bug in the AdministerActions method of AdministerElements.pm, which exists in trunk as well as in 8.8.6. The button names are stored in a hash when an array is appropriate. This commit fixes the bug.
This could already be accomplished by passing a list of users in a group, but with this change it becomes easier to set the required permissions by looking at the MYSQL current permission list. The option is already used in the forms for creating new users or events.
|
Thanks. Aside from the use lib "." I suspect we can incorporate all of this in a future release. No idea when that will come, though. About the permission commit... I'll have to think about this. There is a use case for temporary reviewers where you may want to revoke permissions between reviews for them to see anything but still allow people to create documents viewable by that group when the permission is granted again. |
added 3 commits
April 17, 2024 16:56
changed... See https://stackoverflow.com/questions/59998409/error-code-3685-illegal-argument-to-a-regular-expression This question will probably become more popular as adoption of MySQL 8.0 increases and previously-stored SQL queries using REGEXP start to break. According to MySQL 8.0 Reference Manual / ... / Regular Expressions, "MySQL implements regular expression support using International Components for Unicode (ICU)." According to MySQL 5.6 Reference Manual / ... / Regular Expressions, "MySQL uses Henry Spencer's implementation of regular expressions." Therefore, since you are using MySQL 8.0, rather than using [[:<:]] and [[:>:]], you can now use \b. Your query might look like this: SELECT * FROM `rulebook`.`node__body` WHERE `body_value` REGEXP "\\bDVP\\b" ;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Eric,
When deploying DocDB here I ran into a few issues (some only in my personal computer installation based on an up to date ArchLinux). I also added in a few changes that might be of general interest. Feel free to cherry-pick what you find interesting or let me know what you want so I can make a separate pull request.
As I had the same issue with changing boxes as @meeg I cherry picked the corresponding commit that was already proposed.
For reference commits 196b035 0fc333e 026adce were needed to get DocDB running on ArchLinux, though the first 2 ones might be of general interest.
Commit 4f28fed solves an issue I had with importing events from DocDB into a calendar application (I tested both korganizer and the apple calendar app) where the timezone separation from DTSTART and DTEND with a colon was not recognized so no event was added.
Commit 0bcb322 fixes a deprecation warning that was poluting my apache logs
Commit 5348f78 changes which users are shown on the document/event forms to show only users that have the permission to view in "Can View" and only users with modify permissions in "Can Modify".
Cheers,
João Pedro