Complex scenarios testing #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2588155899
💛 - Coveralls |
rename WalletSign to SignTransaction, move SubmitTransaction, SignTransaction to node_interface;
greenhat
force-pushed
the
i52-test-complex
branch
from
895b344
to
00ba9a5
Compare
kettlebell
approved these changes
Jul 1, 2022
| @@ -451,7 +424,7 @@ pub fn perform_bootstrap_chained_transaction( | |||
|
|
|||
| let target_balance = calc_target_balance(num_transactions_left)?; | |||
| let box_selector = SimpleBoxSelector::new(); | |||
| let mut inputs = filter_tx_outputs(signed_mint_reward_tokens_tx.outputs.clone()); | |||
| let mut inputs = filter_tx_outputs(signed_pool_box_tx.outputs.clone()); | |||
There was a problem hiding this comment.
Thanks for the bug fix!
There was a problem hiding this comment.
My pleasure. I was happy to see that simulation was able to catch this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #52
Todo:
With API drafted and bootstrap testing implemented I'd prefer to merge it as is and continue to implement the full scenario from #52 in the subsequent PRs.