Merge pull request #3 from localheinz/fix/private

Fix: Ignore definitions with private constructors

src/Definitions.php

@@ -58,7 +58,7 @@ public static function in($directory)
                     continue;
                 }
 
-                if (!$reflection->isSubclassOf(Definition::class) || $reflection->isAbstract()) {
+                if (!$reflection->isSubclassOf(Definition::class) || !$reflection->isInstantiable()) {
                     continue;
                 }
 

test/Unit/Asset/Definition/PrivateConstructor/UserDefinition.php

@@ -0,0 +1,30 @@
+<?php
+
+/**
+ * Copyright (c) 2017 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ *
+ * @link https://github.com/localheinz/factory-girl-definition
+ */
+
+namespace Localheinz\FactoryGirl\Definition\Test\Unit\Asset\Definition\PrivateConstructor;
+
+use FactoryGirl\Provider\Doctrine\FixtureFactory;
+use Localheinz\FactoryGirl\Definition\Definition;
+
+/**
+ * Is not acceptable as it has a private constructor.
+ */
+final class UserDefinition implements Definition
+{
+    private function __construct()
+    {
+    }
+
+    public function accept(FixtureFactory $factory)
+    {
+        $factory->defineEntity('Foo');
+    }
+}

test/Unit/DefinitionsTest.php

@@ -73,6 +73,17 @@ public function testInIgnoresClassesWhichAreAbstract()
         Definitions::in(__DIR__ . '/Asset/Definition/IsAbstract')->registerWith($fixtureFactory);
     }
 
+    public function testInIgnoresClassesWhichHavePrivateConstructors()
+    {
+        $fixtureFactory = $this->createFixtureFactoryMock();
+
+        $fixtureFactory
+            ->expects($this->never())
+            ->method($this->anything());
+
+        Definitions::in(__DIR__ . '/Asset/Definition/PrivateConstructor')->registerWith($fixtureFactory);
+    }
+
     public function testInAcceptsClassesWhichAreAcceptable()
     {
         $fixtureFactory = $this->createFixtureFactoryMock();