Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update IPlugin, IPluginManager, IAccountLoupe, BaseModularAccount to match spec update 6 #13

Merged
merged 8 commits into from
Nov 29, 2023

Conversation

fangting-alchemy
Copy link
Collaborator

@fangting-alchemy fangting-alchemy commented Nov 28, 2023

Bringing Ref Impl to ERC-6900 Spec update 6.

  • update IPlugin
  • update IPluginManager
  • update IAccountLoupe
  • update BaseModularAccount to PluginManagerInternals

@fangting-alchemy fangting-alchemy changed the title update IPluginManager update IPluginManager to match spec update 6 Nov 28, 2023
@fangting-alchemy fangting-alchemy changed the title update IPluginManager to match spec update 6 update IPluginManager, IAccountLoupe, BaseModularAccount to match spec update 6 Nov 28, 2023
@fangting-alchemy fangting-alchemy changed the title update IPluginManager, IAccountLoupe, BaseModularAccount to match spec update 6 update IPlugin, IPluginManager, IAccountLoupe, BaseModularAccount to match spec update 6 Nov 29, 2023
Copy link
Contributor

@adam-alchemy adam-alchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@fangting-alchemy fangting-alchemy merged commit d9900e5 into spec-update-6 Nov 29, 2023
3 checks passed
@fangting-alchemy fangting-alchemy deleted the ft_update branch January 10, 2024 19:47
@sm-stack sm-stack mentioned this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants