Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Execution to Call, and update IStandardExecutor #12

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Rename Execution to Call, and update IStandardExecutor #12

merged 2 commits into from
Nov 29, 2023

Conversation

adam-alchemy
Copy link
Contributor

Motivation

To match ERC-6900 Spec Update 6, we need to perform some updates in IStandardExecutor.

Solution

  • Rename Execution to Call, and move into IStandardExecutor.
  • Update execute to take the underlying parameters, rather than a struct.

@adam-alchemy adam-alchemy changed the base branch from main to spec-update-6 November 28, 2023 21:29
fangting-alchemy
fangting-alchemy approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@fangting-alchemy fangting-alchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor doc comment on other executors.

@adam-alchemy adam-alchemy merged commit b4755df into spec-update-6 Nov 29, 2023
3 checks passed
@jaypaik jaypaik deleted the adam/istandardexecutor-update branch January 11, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangting-alchemy fangting-alchemy fangting-alchemy approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson

@jaypaik jaypaik Awaiting requested review from jaypaik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adam-alchemy @fangting-alchemy @adamegyed