TST: Fix various warnings emitted from tests #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a few warnings related to accessing things. Removing the `inplace=True` qualifier seems undesirable despite the warning being emitted for it, but it turns out that generally when this is given pandas is creating a copy internally anyway. pandas seem to have a general desire to remove the `inplace=` options everywhere so that code is not mutating, but remains more immutable. See the following comment from years ago. pandas-dev/pandas#16529 (comment)
pytest.PytestRemovedInWarning: Marks applied to fixtures have no effect
mferrera
force-pushed
the
fix-pandas-warnings
branch
from
3f98beb to
cb916de
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
==========================================
+ Coverage 80.02% 80.04% +0.01%
==========================================
Files 98 98
Lines 13680 13683 +3
Branches 2203 2202 -1
==========================================
+ Hits 10948 10952 +4
+ Misses 1999 1996 -3
- Partials 733 735 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1216
Reduces the number of warnings from 4000 to 1500. The remaining ones are mostly self-emitted for xtgeo 4.0 deprecations, with a few numpy ones.
A big-looking change is the removal of
inplace=arguments. See the commit comment for a longer description, but tl;dr this didn't actually do things inplace but on a copy internally. See pandas-dev/pandas#51466